DEV: Renaming TopicsController defer track visit (#27761)

Followup to 527f02e99f,
I had to introduce defer_track_visit_v2 because discourse-docs
relied on defer_track_visit. Now that discourse-docs
is using the new method as of
discourse/discourse-docs@0d9365571b,
we can rename it in core. Then we will need one more PR
in both core and docs to remove usage of the "v2" method.
This commit is contained in:
Martin Brennan 2024-07-08 16:00:20 +10:00 committed by GitHub
parent c3598847fe
commit b46e1fe2aa
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 6 deletions

View File

@ -1285,16 +1285,15 @@ class TopicsController < ApplicationController
TopicsController.defer_track_visit_v2(topic_id, user_id) if should_track_visit_to_topic?
end
# TODO (martin) Remove this once discourse-docs is updated.
def self.defer_track_visit(topic_id, ip, user_id, track_visit)
self.defer_track_visit_v2(topic_id, user_id) if track_visit
self.defer_topic_view(topic_id, ip, user_id)
end
def self.defer_track_visit_v2(topic_id, user_id)
def self.defer_track_visit(topic_id, user_id)
Scheduler::Defer.later "Track Visit" do
TopicUser.track_visit!(topic_id, user_id)
end
end
# TODO (martin) Remove this once discourse-docs is updated.
def self.defer_track_visit_v2(topic_id, user_id)
defer_track_visit(topic_id, user_id)
end
def self.defer_topic_view(topic_id, ip, user_id = nil)
Scheduler::Defer.later "Topic View" do