DEV: Update ember-template-lint (#22242)

This commit is contained in:
Jarek Radosz 2023-06-22 22:54:46 +02:00 committed by GitHub
parent 6f8056572e
commit ba62d20f71
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
19 changed files with 42 additions and 62 deletions

View File

@ -5,6 +5,7 @@ module.exports = {
rules: {
"no-action-modifiers": true,
"no-args-paths": true,
"no-array-prototype-extensions": false,
"no-attrs-in-components": true,
"no-capital-arguments": false, // TODO: we extensively use `args` argument name
"no-curly-component-invocation": {
@ -21,6 +22,10 @@ module.exports = {
"no-implicit-this": {
allow: ["loading-spinner"],
},
"no-negated-condition": false,
"no-obscure-array-access": false,
"require-mandatory-role-attributes": false,
"require-media-caption": false,
// Begin prettier compatibility
"eol-last": false,
"self-closing-void-elements": false,

View File

@ -1,4 +1,4 @@
{{! template-lint-disable no-down-event-binding }}
{{! template-lint-disable no-pointer-down-event-binding }}
<button
{{! For legacy compatibility. Prefer passing class as attributes. }}
class={{concat-class

View File

@ -1,4 +1,4 @@
{{! template-lint-disable no-down-event-binding }}
{{! template-lint-disable no-pointer-down-event-binding }}
{{! template-lint-disable no-invalid-interactive }}
<div

View File

@ -1,14 +1,14 @@
<div class="d-toggle-switch">
<label class="d-toggle-switch--label">
{{! template-lint-disable no-unnecessary-concat }}
{{! template-lint-disable no-redundant-role }}
<button
class="d-toggle-switch__checkbox"
type="button"
role="switch"
aria-checked="{{@state}}"
aria-checked={{this.checked}}
...attributes
></button>
{{! template-lint-enable no-unnecessary-concat }}
{{! template-lint-enable no-redundant-role }}
<span class="d-toggle-switch__checkbox-slider">
{{#if @state}}

View File

@ -1,15 +1,15 @@
import Component from "@glimmer/component";
import { tracked } from "@glimmer/tracking";
import I18n from "I18n";
export default class DiscourseToggleSwitch extends Component {
@tracked iconEnabled = true;
@tracked showIcon = this.iconEnabled && this.icon;
export default class DToggleSwitch extends Component {
get computedLabel() {
if (this.args.label) {
return I18n.t(this.args.label);
}
return this.args.translatedLabel;
}
get checked() {
return this.args.state ? "true" : "false";
}
}

View File

@ -1,10 +1,10 @@
{{#if this.isActive}}
{{! template-lint-disable no-invalid-interactive no-down-event-binding }}
{{! template-lint-disable no-invalid-interactive no-pointer-down-event-binding }}
<div
{{on "keydown" (action "keydown")}}
class="emoji-picker {{if this.isActive 'opened'}}"
>
{{! template-lint-enable no-invalid-interactive no-down-event-binding }}
{{! template-lint-enable no-invalid-interactive no-pointer-down-event-binding }}
<div class="emoji-picker-category-buttons">
{{#if this.recentEmojis.length}}
<button

View File

@ -86,7 +86,6 @@
src={{this.demoAvatarUrl}}
class="avatar actor"
alt=""
role="presentation"
/>
</div>

View File

@ -1,4 +1,4 @@
{{! template-lint-disable no-down-event-binding }}
{{! template-lint-disable no-pointer-down-event-binding }}
{{! template-lint-disable no-invalid-interactive }}
<nav

View File

@ -1,4 +1,4 @@
{{! template-lint-disable no-down-event-binding }}
{{! template-lint-disable no-pointer-down-event-binding }}
{{! template-lint-disable no-invalid-interactive }}
<li
class="search-menu-assistant-item"

View File

@ -5,7 +5,7 @@
aria-label={{concat (i18n "search.results") " " resultType.type}}
>
{{#each resultType.results as |result|}}
{{! template-lint-disable no-down-event-binding }}
{{! template-lint-disable no-pointer-down-event-binding }}
{{! template-lint-disable no-invalid-interactive }}
<li class="item" {{on "keydown" this.onKeydown}}>
<a href={{(or result.url result.path)}} class="search-link">

View File

@ -17,13 +17,13 @@
"postinstall": "yarn --silent --cwd .. patch-package"
},
"dependencies": {
"@ember/string": "^3.1.1",
"@discourse/backburner.js": "^2.7.1-0",
"@discourse/itsatrap": "^2.0.10",
"@ember-compat/tracked-built-ins": "^0.9.1",
"@ember/jquery": "^2.0.0",
"@ember/legacy-built-in-components": "^0.4.2",
"@ember/render-modifiers": "^2.1.0",
"@ember/string": "^3.1.1",
"@ember/test-helpers": "^2.9.4",
"@glimmer/component": "^1.1.2",
"@glimmer/syntax": "^0.84.3",
@ -99,19 +99,19 @@
"ember-cli-progress-ci": "1.0.0",
"ember-cli-sri": "^2.1.1",
"ember-cli-terser": "^4.0.2",
"ember-exam": "^8.0.0",
"ember-functions-as-helper-polyfill": "^2.1.1",
"ember-qunit": "^6.2.0",
"ember-exam": "^8.0.0",
"eslint": "^8.43.0",
"eslint-plugin-qunit": "^7.3.4",
"imports-loader": "^4.0.1",
"loader.js": "^4.7.0",
"pretender": "^3.4.7",
"qunit": "^2.19.4",
"qunit-dom": "^2.0.0",
"sass": "^1.63.6",
"sinon": "^15.2.0",
"source-map": "^0.7.4",
"qunit": "^2.19.4",
"qunit-dom": "^2.0.0",
"terser": "^5.18.1",
"webpack": "^5.88.0",
"workbox-cacheable-response": "^7.0.0",

View File

@ -1,6 +1,6 @@
{{#unless this.isHidden}}
{{! filter-input-search prevents 1password from attempting autocomplete }}
{{! template-lint-disable no-down-event-binding }}
{{! template-lint-disable no-pointer-down-event-binding }}
<Input
tabindex={{0}}

View File

@ -1,4 +1,4 @@
<h2 class="selected-name" title={{this.title}} role="option">
<h2 class="selected-name" title={{this.title}}>
{{period-title
this.value
showDateRange=true

View File

@ -1,6 +1,6 @@
{{#unless this.isHidden}}
{{! filter-input-search prevents 1password from attempting autocomplete }}
{{! template-lint-disable no-down-event-binding }}
{{! template-lint-disable no-pointer-down-event-binding }}
<Input
tabindex={{0}}

View File

@ -4,7 +4,6 @@
title={{this.title}}
data-value={{this.value}}
data-name={{this.name}}
role="option"
class="select-kit-selected-name selected-name choice"
>
{{#if this.item.icon}}
@ -28,7 +27,6 @@
{{else}}
{{#if this.item.icon}}
<div
role="option"
lang={{this.lang}}
class="select-kit-selected-name selected-name choice"
>

View File

@ -25,7 +25,7 @@
"@mixer/parallel-prettier": "^2.0.3",
"chrome-launcher": "^0.15.1",
"chrome-remote-interface": "^0.31.3",
"ember-template-lint": "4.10.1",
"ember-template-lint": "5.10.3",
"eslint": "^8.37.0",
"eslint-config-discourse": "^3.5.0",
"eslint-plugin-ember": "11.8.0",

View File

@ -1,4 +1,4 @@
{{! template-lint-disable no-down-event-binding }}
{{! template-lint-disable no-pointer-down-event-binding }}
{{! template-lint-disable no-invalid-interactive }}
<div class="chat-composer__wrapper">

View File

@ -1,6 +1,6 @@
{{! template-lint-disable no-invalid-interactive }}
{{! template-lint-disable no-nested-interactive }}
{{! template-lint-disable no-down-event-binding }}
{{! template-lint-disable no-pointer-down-event-binding }}
{{#if (eq this.chatEmojiPickerManager.picker.context @context)}}
<div

View File

@ -642,7 +642,7 @@ argparse@^2.0.1:
resolved "https://registry.yarnpkg.com/argparse/-/argparse-2.0.1.tgz#246f50f3ca78a3240f6c997e8a9bd1eac49e4b38"
integrity sha512-8+9WqebbFzpX9OR+Wa6O29asIogeRMzcGtAINdpMHHyAg10f05aSFVBbcEqGf/PXw1EjAZ+q2/bEBg3DvurK3Q==
aria-query@^5.0.0, aria-query@^5.0.2:
aria-query@^5.0.2:
version "5.2.1"
resolved "https://registry.yarnpkg.com/aria-query/-/aria-query-5.2.1.tgz#bc285d9d654d1df121bcd0c134880d415ca67c15"
integrity sha512-7uFg4b+lETFgdaJyETnILsXgnnzVnkHcgRbwbPwevm5x/LmUlt3MjczMRe1zg824iBgXZNRPTBftNYyRSKLp2g==
@ -999,7 +999,7 @@ chrome-remote-interface@^0.31.3:
commander "2.11.x"
ws "^7.2.0"
ci-info@^3.3.2, ci-info@^3.8.0:
ci-info@^3.8.0:
version "3.8.0"
resolved "https://registry.yarnpkg.com/ci-info/-/ci-info-3.8.0.tgz#81408265a5380c929f0bc665d62256628ce9ef91"
integrity sha512-eXTggHWSooYhq49F2opQhuHWgzucfF2YgODK4e1566GQs5BIfP30B0oenwBJHfWxAs2fyPB1s7Mg949zLf61Yw==
@ -1143,7 +1143,7 @@ css-tree@^2.0.4:
mdn-data "2.0.30"
source-map-js "^1.0.1"
date-fns@^2.28.0, date-fns@^2.30.0:
date-fns@^2.30.0:
version "2.30.0"
resolved "https://registry.yarnpkg.com/date-fns/-/date-fns-2.30.0.tgz#f367e644839ff57894ec6ac480de40cae4b0f4d0"
integrity sha512-fnULvOpxnC5/Vg3NCiWelDsLiUc9bRwAPs/+LfTLNvetFCtCTN+yQz15C/fs4AwX1R9K5GLtLfn8QW+dWisaAw==
@ -1244,9 +1244,9 @@ editions@^1.1.1:
integrity sha512-gzao+mxnYDzIysXKMQi/+M1mjy/rjestjg6OPoYTtI+3Izp23oiGZitsl9lPDPiTGXbcSIk1iJWhliSaglxnUg==
electron-to-chromium@^1.4.431:
version "1.4.435"
resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.4.435.tgz#761c34300603b9f1234f0b6155870d3002435db6"
integrity sha512-B0CBWVFhvoQCW/XtjRzgrmqcgVWg6RXOEM/dK59+wFV93BFGR6AeNKc4OyhM+T3IhJaOOG8o/V+33Y2mwJWtzw==
version "1.4.436"
resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.4.436.tgz#2aa6e1644693d25cb438a873fba72ec901e1be30"
integrity sha512-aktOxo8fnrMC8vOIBMVS3PXbT1nrPQ+SouUuN7Y0a+Rw3pOMrvIV92Ybnax7x4tugA+ZpYA5fOHTby7ama8OQQ==
ember-cli-babel-plugin-helpers@^1.1.1:
version "1.1.1"
@ -1287,29 +1287,7 @@ ember-template-lint-plugin-discourse@^3.0.0:
resolved "https://registry.yarnpkg.com/ember-template-lint-plugin-discourse/-/ember-template-lint-plugin-discourse-3.0.0.tgz#9212226e4d2f6dce2e35b480aaf240067d736246"
integrity sha512-4zi/qN+vXs0ZpJZrwdMfZ5hMThJbeVCFdof6iek4PmgIJhnlA0lzqIa1BrKpSKhr3ckd5K0rUMNcCAm0uKNOtg==
ember-template-lint@4.10.1:
version "4.10.1"
resolved "https://registry.yarnpkg.com/ember-template-lint/-/ember-template-lint-4.10.1.tgz#2c348187a7bce15f0fdf371f6f3f54e3717b0a0a"
integrity sha512-uFJ4jjzbYuVKTeTEVqzLDQR7XHFbSLQDZoFC6XZ3OMxX07YArmM78MKBOAJ6ri9fVCd1LD9j99j6qXwUWqWr1g==
dependencies:
"@lint-todo/utils" "^13.0.3"
aria-query "^5.0.0"
chalk "^4.1.2"
ci-info "^3.3.2"
date-fns "^2.28.0"
ember-template-recast "^6.1.3"
find-up "^6.3.0"
fuse.js "^6.5.3"
get-stdin "^9.0.0"
globby "^13.1.2"
is-glob "^4.0.3"
language-tags "^1.0.5"
micromatch "^4.0.5"
resolve "^1.22.1"
v8-compile-cache "^2.3.0"
yargs "^17.5.1"
ember-template-lint@^5.10.3:
ember-template-lint@5.10.3, ember-template-lint@^5.10.3:
version "5.10.3"
resolved "https://registry.yarnpkg.com/ember-template-lint/-/ember-template-lint-5.10.3.tgz#919f69de7e4ac08c095edf39c6e6275acd363dcf"
integrity sha512-IuvnJnCN36vnFoDUQ4TPiS9SsoMtvS3hL+zsdNpd+f3ZqKrlXSfcdyRqjKLrucbYE34Lk5BKpbYv68YZ86N69w==
@ -1333,7 +1311,7 @@ ember-template-lint@^5.10.3:
v8-compile-cache "^2.3.0"
yargs "^17.7.2"
ember-template-recast@^6.1.3, ember-template-recast@^6.1.4:
ember-template-recast@^6.1.4:
version "6.1.4"
resolved "https://registry.yarnpkg.com/ember-template-recast/-/ember-template-recast-6.1.4.tgz#e964c184adfd876878009f8aa0b84c95633fce20"
integrity sha512-fCh+rOK6z+/tsdkTbOE+e7f84P6ObnIRQrCCrnu21E4X05hPeradikIkRMhJdxn4NWrxitfZskQDd37TR/lsNQ==
@ -2009,7 +1987,7 @@ globby@^11.0.3:
merge2 "^1.4.1"
slash "^3.0.0"
globby@^13.1.2, globby@^13.1.4:
globby@^13.1.4:
version "13.2.0"
resolved "https://registry.yarnpkg.com/globby/-/globby-13.2.0.tgz#7dd5678d765c4680c2e6d106230d86cb727cb1af"
integrity sha512-jWsQfayf13NvqKUIL3Ta+CIqMnvlaIDFveWE/dpOZ9+3AMEJozsxDvKA02zync9UuvOM8rOXzsD5GqKP4OnWPQ==
@ -2500,7 +2478,7 @@ language-subtag-registry@^0.3.20:
resolved "https://registry.yarnpkg.com/language-subtag-registry/-/language-subtag-registry-0.3.22.tgz#2e1500861b2e457eba7e7ae86877cbd08fa1fd1d"
integrity sha512-tN0MCzyWnoz/4nHS6uxdlFWoUZT7ABptwKPQ52Ea7URk6vll88bWBVhodtnlfEuCcKWNGoc+uGbw1cwa9IKh/w==
language-tags@^1.0.5, language-tags@^1.0.8:
language-tags@^1.0.8:
version "1.0.8"
resolved "https://registry.yarnpkg.com/language-tags/-/language-tags-1.0.8.tgz#042b4bdb0d4e771a9f8cc2fdc9bb26a52a367312"
integrity sha512-aWAZwgPLS8hJ20lNPm9HNVs4inexz6S2sQa3wx/+ycuutMNE5/IfYxiWYBbi+9UWCQVaXYCOPUl6gFrPR7+jGg==
@ -3287,7 +3265,7 @@ resolve-package-path@^3.1.0:
path-root "^0.1.1"
resolve "^1.17.0"
resolve@^1.10.0, resolve@^1.10.1, resolve@^1.11.1, resolve@^1.17.0, resolve@^1.22.1, resolve@^1.22.3:
resolve@^1.10.0, resolve@^1.10.1, resolve@^1.11.1, resolve@^1.17.0, resolve@^1.22.3:
version "1.22.3"
resolved "https://registry.yarnpkg.com/resolve/-/resolve-1.22.3.tgz#4b4055349ffb962600972da1fdc33c46a4eb3283"
integrity sha512-P8ur/gp/AmbEzjr729bZnLjXK5Z+4P0zhIJgBgzqRih7hL7BOukHGtSTA3ACMY467GRFz3duQsi0bDZdR7DKdw==
@ -4032,7 +4010,7 @@ yargs-parser@^21.1.1:
resolved "https://registry.yarnpkg.com/yargs-parser/-/yargs-parser-21.1.1.tgz#9096bceebf990d21bb31fa9516e0ede294a77d35"
integrity sha512-tVpsJW7DdjecAiFpbIB1e3qxIQsE6NoPc5/eTdrbbIC4h0LVsWhnoa3g+m2HclBIujHzsxZ4VJVA+GUuc2/LBw==
yargs@^17.5.1, yargs@^17.7.2:
yargs@^17.7.2:
version "17.7.2"
resolved "https://registry.yarnpkg.com/yargs/-/yargs-17.7.2.tgz#991df39aca675a192b816e1e0363f9d75d2aa269"
integrity sha512-7dSzzRQ++CKnNI/krKnYRV7JKKPUXMEh61soaHKg9mrWEhzFWhFnxPxGl+69cD1Ou63C13NUPCnmIcrvqCuM6w==