Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Skip failing flaky tests for now (#15605) 

At Sam's request, these are causing a lot of build
problems right now.
This commit is contained in:
Martin Brennan 2022-01-17 15:43:38 +10:00 committed by GitHub
parent 35343e7f91
commit bc8cb38081
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
10 changed files with 120 additions and 142 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
app/assets/javascripts/discourse/tests/acceptance/bookmarks-test.js
View File

@ -8,7 +8,7 @@ import {
import { click, fillIn, visit } from "@ember/test-helpers";
import I18n from "I18n";
import selectKit from "discourse/tests/helpers/select-kit-helper";
import { test } from "qunit";
import { skip } from "qunit";
import topicFixtures from "discourse/tests/fixtures/topic";
import { cloneJSON } from "discourse-common/lib/object";
@ -104,7 +104,7 @@ acceptance("Bookmarking", function (needs) {
server.get("/t/280.json", () => helper.response(topicResponse));
});
test("Bookmarks modal opening", async function (assert) {
skip("Bookmarks modal opening", async function (assert) {
await visit("/t/internationalization-localization/280");
await openBookmarkModal();
assert.ok(
@ -113,7 +113,7 @@ acceptance("Bookmarking", function (needs) {
);
});
test("Bookmarks modal selecting reminder type", async function (assert) {
skip("Bookmarks modal selecting reminder type", async function (assert) {
await visit("/t/internationalization-localization/280");
await openBookmarkModal();
@ -133,7 +133,7 @@ acceptance("Bookmarking", function (needs) {
await click("#save-bookmark");
});
test("Saving a bookmark with a reminder", async function (assert) {
skip("Saving a bookmark with a reminder", async function (assert) {
await visit("/t/internationalization-localization/280");
await openBookmarkModal();
await fillIn("input#bookmark-name", "Check this out later");
@ -151,7 +151,7 @@ acceptance("Bookmarking", function (needs) {
);
});
test("Opening the options panel and remembering the option", async function (assert) {
skip("Opening the options panel and remembering the option", async function (assert) {
await visit("/t/internationalization-localization/280");
await openBookmarkModal();
await click(".bookmark-options-button");
@ -174,7 +174,7 @@ acceptance("Bookmarking", function (needs) {
);
});
test("Saving a bookmark with no reminder or name", async function (assert) {
skip("Saving a bookmark with no reminder or name", async function (assert) {
await visit("/t/internationalization-localization/280");
await openBookmarkModal();
await click("#save-bookmark");
@ -191,7 +191,7 @@ acceptance("Bookmarking", function (needs) {
);
});
test("Deleting a bookmark with a reminder", async function (assert) {
skip("Deleting a bookmark with a reminder", async function (assert) {
await visit("/t/internationalization-localization/280");
await openBookmarkModal();
await click("#tap_tile_tomorrow");
@ -221,7 +221,7 @@ acceptance("Bookmarking", function (needs) {
);
});
test("Cancelling saving a bookmark", async function (assert) {
skip("Cancelling saving a bookmark", async function (assert) {
await visit("/t/internationalization-localization/280");
await openBookmarkModal();
await click(".d-modal-cancel");
@ -231,7 +231,7 @@ acceptance("Bookmarking", function (needs) {
);
});
test("Editing a bookmark", async function (assert) {
skip("Editing a bookmark", async function (assert) {
await visit("/t/internationalization-localization/280");
let now = moment.tz(loggedInUser().resolvedTimezone(loggedInUser()));
let tomorrow = now.add(1, "day").format("YYYY-MM-DD");
@ -257,7 +257,7 @@ acceptance("Bookmarking", function (needs) {
);
});
test("Using a post date for the reminder date", async function (assert) {
skip("Using a post date for the reminder date", async function (assert) {
await visit("/t/internationalization-localization/280");
let postDate = moment.tz(
"2036-01-15",
@ -286,7 +286,7 @@ acceptance("Bookmarking", function (needs) {
);
});
test("Cannot use the post date for a reminder when the post date is in the past", async function (assert) {
skip("Cannot use the post date for a reminder when the post date is in the past", async function (assert) {
await visit("/t/internationalization-localization/280");
await openBookmarkModal(2);
assert.notOk(
@ -295,7 +295,7 @@ acceptance("Bookmarking", function (needs) {
);
});
test("The topic level bookmark button deletes all bookmarks if several posts on the topic are bookmarked", async function (assert) {
skip("The topic level bookmark button deletes all bookmarks if several posts on the topic are bookmarked", async function (assert) {
const yesButton = "a.btn-primary";
const noButton = "a.btn-default";
@ -341,7 +341,7 @@ acceptance("Bookmarking", function (needs) {
);
});
test("The topic level bookmark button opens the edit modal if only the first post on the topic is bookmarked", async function (assert) {
skip("The topic level bookmark button opens the edit modal if only the first post on the topic is bookmarked", async function (assert) {
await visit("/t/internationalization-localization/280");
await openBookmarkModal(1);
await click("#save-bookmark");
@ -360,7 +360,7 @@ acceptance("Bookmarking", function (needs) {
);
});
test("Creating and editing a topic level bookmark", async function (assert) {
skip("Creating and editing a topic level bookmark", async function (assert) {
await visit("/t/internationalization-localization/280");
await click("#topic-footer-button-bookmark");
@ -432,7 +432,7 @@ acceptance("Bookmarking", function (needs) {
);
});
test("Deleting a topic_level bookmark with a reminder", async function (assert) {
skip("Deleting a topic_level bookmark with a reminder", async function (assert) {
await visit("/t/internationalization-localization/280");
await click("#topic-footer-button-bookmark");
await click("#save-bookmark");
@ -467,7 +467,7 @@ acceptance("Bookmarking", function (needs) {
);
});
test("The topic level bookmark button opens the edit modal if only one post in the post stream is bookmarked", async function (assert) {
skip("The topic level bookmark button opens the edit modal if only one post in the post stream is bookmarked", async function (assert) {
await visit("/t/internationalization-localization/280");
await openBookmarkModal(2);
await click("#save-bookmark");
@ -486,12 +486,12 @@ acceptance("Bookmarking", function (needs) {
);
});
test("The topic level bookmark button shows an icon with a clock if there is a bookmark with a reminder on the first post", async function (assert) {
skip("The topic level bookmark button shows an icon with a clock if there is a bookmark with a reminder on the first post", async function (assert) {
const postNumber = 1;
await testTopicLevelBookmarkButtonIcon(assert, postNumber);
});
test("The topic level bookmark button shows an icon with a clock if there is a bookmark with a reminder on the second post", async function (assert) {
skip("The topic level bookmark button shows an icon with a clock if there is a bookmark with a reminder on the second post", async function (assert) {
const postNumber = 2;
await testTopicLevelBookmarkButtonIcon(assert, postNumber);
});

5
app/assets/javascripts/discourse/tests/acceptance/click-track-test.js
View File

@ -4,7 +4,8 @@ import {
exists,
} from "discourse/tests/helpers/qunit-helpers";
import { click, currentURL, visit } from "@ember/test-helpers";
import { test } from "qunit";
import { skip } from "qunit";
// import { test } from "qunit";
acceptance("Click Track", function (needs) {
let tracked = false;
@ -15,7 +16,7 @@ acceptance("Click Track", function (needs) {
});
});
test("Do not track mentions", async function (assert) {
skip("Do not track mentions", async function (assert) {
await visit("/t/internationalization-localization/280");
assert.ok(!exists(".user-card.show"), "card should not appear");

10
app/assets/javascripts/discourse/tests/acceptance/composer-actions-test.js
View File

@ -13,7 +13,7 @@ import { Promise } from "rsvp";
import { _clearSnapshots } from "select-kit/components/composer-actions";
import selectKit from "discourse/tests/helpers/select-kit-helper";
import sinon from "sinon";
import { test } from "qunit";
import { skip, test } from "qunit";
import { toggleCheckDraftPopup } from "discourse/controllers/composer";
acceptance("Composer Actions", function (needs) {
@ -35,7 +35,7 @@ acceptance("Composer Actions", function (needs) {
assert.ok(queryAll(".d-editor-input").val(), "this is the reply");
});
test("replying to post", async function (assert) {
skip("replying to post", async function (assert) {
const composerActions = selectKit(".composer-actions");
await visit("/t/internationalization-localization/280");
@ -76,7 +76,7 @@ acceptance("Composer Actions", function (needs) {
);
});
test("replying to post - reply_to_topic", async function (assert) {
skip("replying to post - reply_to_topic", async function (assert) {
const composerActions = selectKit(".composer-actions");
await visit("/t/internationalization-localization/280");
@ -103,7 +103,7 @@ acceptance("Composer Actions", function (needs) {
);
});
test("replying to post - toggle_whisper", async function (assert) {
skip("replying to post - toggle_whisper", async function (assert) {
const composerActions = selectKit(".composer-actions");
await visit("/t/internationalization-localization/280");
@ -405,7 +405,7 @@ acceptance("Composer Actions", function (needs) {
);
});
test("replying to post as TL3 user", async function (assert) {
skip("replying to post as TL3 user", async function (assert) {
const composerActions = selectKit(".composer-actions");
updateCurrentUser({ moderator: false, admin: false, trust_level: 3 });

4
app/assets/javascripts/discourse/tests/acceptance/composer-test.js
View File

@ -234,7 +234,7 @@ acceptance("Composer", function (needs) {
);
});
test("Posting on a different topic", async function (assert) {
skip("Posting on a different topic", async function (assert) {
await visit("/t/internationalization-localization/280");
await click("#topic-footer-buttons .btn.create");
await fillIn(
@ -686,7 +686,7 @@ acceptance("Composer", function (needs) {
}
});
test("Can switch states without abandon popup", async function (assert) {
skip("Can switch states without abandon popup", async function (assert) {
try {
toggleCheckDraftPopup(true);

4
app/assets/javascripts/discourse/tests/acceptance/fast-edit-test.js
View File

@ -5,7 +5,7 @@ import {
selectText,
} from "discourse/tests/helpers/qunit-helpers";
import { click, fillIn, triggerKeyEvent, visit } from "@ember/test-helpers";
import { test } from "qunit";
import { skip, test } from "qunit";
import postFixtures from "discourse/tests/fixtures/post";
import { cloneJSON } from "discourse-common/lib/object";
@ -62,7 +62,7 @@ acceptance("Fast Edit", function (needs) {
assert.notOk(exists("#fast-edit-input"), "fast editor is closed");
});
test("Opens full composer for multi-line selection", async function (assert) {
skip("Opens full composer for multi-line selection", async function (assert) {
await visit("/t/internationalization-localization/280");
const textNode = query("#post_2 .cooked");

4
app/assets/javascripts/discourse/tests/acceptance/jump-to-test.js
View File

@ -1,6 +1,6 @@
import { acceptance, exists } from "discourse/tests/helpers/qunit-helpers";
import { click, currentURL, fillIn, visit } from "@ember/test-helpers";
import { test } from "qunit";
import { skip, test } from "qunit";
acceptance("Jump to", function (needs) {
needs.user();
@ -37,7 +37,7 @@ acceptance("Jump to", function (needs) {
);
});
test("invalid date", async function (assert) {
skip("invalid date", async function (assert) {
await visit("/t/internationalization-localization/280");
await click("nav#topic-progress .nums");
await click("button.jump-to-post");

4
app/assets/javascripts/discourse/tests/acceptance/post-history-test.js
View File

@ -4,7 +4,7 @@ import {
count,
query,
} from "discourse/tests/helpers/qunit-helpers";
import { test } from "qunit";
import { skip } from "qunit";
acceptance("Post - History", function (needs) {
needs.user();
@ -51,7 +51,7 @@ acceptance("Post - History", function (needs) {
});
});
test("Shows highlighted tag changes", async function (assert) {
skip("Shows highlighted tag changes", async function (assert) {
await visit("/t/internationalization-localization/280");
await click("article[data-post-id='419'] .edits button");
assert.equal(count(".discourse-tag"), 4);

155
app/assets/javascripts/discourse/tests/acceptance/topic-quote-button-test.js
View File

@ -1,13 +1,12 @@
import {
acceptance,
chromeTest,
exists,
queryAll,
selectText,
} from "discourse/tests/helpers/qunit-helpers";
import I18n from "I18n";
import { click, triggerKeyEvent, visit } from "@ember/test-helpers";
import { test } from "qunit";
import { skip, test } from "qunit";
// This tests are flaky on Firefox. Fails with `calling set on destroyed object`
acceptance("Topic - Quote button - logged in", function (needs) {
@ -17,50 +16,42 @@ acceptance("Topic - Quote button - logged in", function (needs) {
share_quote_buttons: "twitter|email",
});
chromeTest(
"Does not show the quote share buttons by default",
async function (assert) {
await visit("/t/internationalization-localization/280");
await selectText("#post_5 blockquote");
assert.ok(exists(".insert-quote"), "it shows the quote button");
assert.ok(!exists(".quote-sharing"), "it does not show quote sharing");
}
);
// All these skips were chromeTest
skip("Does not show the quote share buttons by default", async function (assert) {
await visit("/t/internationalization-localization/280");
await selectText("#post_5 blockquote");
assert.ok(exists(".insert-quote"), "it shows the quote button");
assert.ok(!exists(".quote-sharing"), "it does not show quote sharing");
});
chromeTest(
"Shows quote share buttons with the right site settings",
async function (assert) {
this.siteSettings.share_quote_visibility = "all";
skip("Shows quote share buttons with the right site settings", async function (assert) {
this.siteSettings.share_quote_visibility = "all";
await visit("/t/internationalization-localization/280");
await selectText("#post_5 blockquote");
await visit("/t/internationalization-localization/280");
await selectText("#post_5 blockquote");
assert.ok(exists(".quote-sharing"), "it shows the quote sharing options");
assert.ok(
exists(`.quote-sharing .btn[title='${I18n.t("share.twitter")}']`),
"it includes the twitter share button"
);
assert.ok(
exists(`.quote-sharing .btn[title='${I18n.t("share.email")}']`),
"it includes the email share button"
);
}
);
assert.ok(exists(".quote-sharing"), "it shows the quote sharing options");
assert.ok(
exists(`.quote-sharing .btn[title='${I18n.t("share.twitter")}']`),
"it includes the twitter share button"
);
assert.ok(
exists(`.quote-sharing .btn[title='${I18n.t("share.email")}']`),
"it includes the email share button"
);
});
chromeTest(
"Quoting a Onebox should not copy the formatting of the rendered Onebox",
async function (assert) {
await visit("/t/topic-for-group-moderators/2480");
await selectText("#post_3 aside.onebox p");
await click(".insert-quote");
skip("Quoting a Onebox should not copy the formatting of the rendered Onebox", async function (assert) {
await visit("/t/topic-for-group-moderators/2480");
await selectText("#post_3 aside.onebox p");
await click(".insert-quote");
assert.strictEqual(
queryAll(".d-editor-input").val().trim(),
'[quote="group_moderator, post:3, topic:2480"]\nhttps://example.com/57350945\n[/quote]',
"quote only contains a link"
);
}
);
assert.strictEqual(
queryAll(".d-editor-input").val().trim(),
'[quote="group_moderator, post:3, topic:2480"]\nhttps://example.com/57350945\n[/quote]',
"quote only contains a link"
);
});
});
acceptance("Topic - Quote button - anonymous", function (needs) {
@ -69,60 +60,48 @@ acceptance("Topic - Quote button - anonymous", function (needs) {
share_quote_buttons: "twitter|email",
});
chromeTest(
"Shows quote share buttons with the right site settings",
async function (assert) {
await visit("/t/internationalization-localization/280");
await selectText("#post_5 blockquote");
skip("Shows quote share buttons with the right site settings", async function (assert) {
await visit("/t/internationalization-localization/280");
await selectText("#post_5 blockquote");
assert.ok(
queryAll(".quote-sharing"),
"it shows the quote sharing options"
);
assert.ok(
exists(`.quote-sharing .btn[title='${I18n.t("share.twitter")}']`),
"it includes the twitter share button"
);
assert.ok(
exists(`.quote-sharing .btn[title='${I18n.t("share.email")}']`),
"it includes the email share button"
);
assert.ok(!exists(".insert-quote"), "it does not show the quote button");
}
);
assert.ok(queryAll(".quote-sharing"), "it shows the quote sharing options");
assert.ok(
exists(`.quote-sharing .btn[title='${I18n.t("share.twitter")}']`),
"it includes the twitter share button"
);
assert.ok(
exists(`.quote-sharing .btn[title='${I18n.t("share.email")}']`),
"it includes the email share button"
);
assert.ok(!exists(".insert-quote"), "it does not show the quote button");
});
chromeTest(
"Shows single share button when site setting only has one item",
async function (assert) {
this.siteSettings.share_quote_buttons = "twitter";
skip("Shows single share button when site setting only has one item", async function (assert) {
this.siteSettings.share_quote_buttons = "twitter";
await visit("/t/internationalization-localization/280");
await selectText("#post_5 blockquote");
await visit("/t/internationalization-localization/280");
await selectText("#post_5 blockquote");
assert.ok(exists(".quote-sharing"), "it shows the quote sharing options");
assert.ok(
exists(`.quote-sharing .btn[title='${I18n.t("share.twitter")}']`),
"it includes the twitter share button"
);
assert.ok(
!exists(".quote-share-label"),
"it does not show the Share label"
);
}
);
assert.ok(exists(".quote-sharing"), "it shows the quote sharing options");
assert.ok(
exists(`.quote-sharing .btn[title='${I18n.t("share.twitter")}']`),
"it includes the twitter share button"
);
assert.ok(
!exists(".quote-share-label"),
"it does not show the Share label"
);
});
chromeTest(
"Shows nothing when visibility is disabled",
async function (assert) {
this.siteSettings.share_quote_visibility = "none";
skip("Shows nothing when visibility is disabled", async function (assert) {
this.siteSettings.share_quote_visibility = "none";
await visit("/t/internationalization-localization/280");
await selectText("#post_5 blockquote");
await visit("/t/internationalization-localization/280");
await selectText("#post_5 blockquote");
assert.ok(!exists(".quote-sharing"), "it does not show quote sharing");
assert.ok(!exists(".insert-quote"), "it does not show the quote button");
}
);
assert.ok(!exists(".quote-sharing"), "it does not show quote sharing");
assert.ok(!exists(".insert-quote"), "it does not show the quote button");
});
});
acceptance("Topic - Quote button - keyboard shortcut", function (needs) {

36
app/assets/javascripts/discourse/tests/acceptance/topic-test.js
View File

@ -1,6 +1,5 @@
import {
acceptance,
chromeTest,
count,
exists,
query,
@ -17,7 +16,7 @@ import {
} from "@ember/test-helpers";
import I18n from "I18n";
import selectKit from "discourse/tests/helpers/select-kit-helper";
import { test } from "qunit";
import { skip, test } from "qunit";
import { withPluginApi } from "discourse/lib/plugin-api";
import topicFixtures from "discourse/tests/fixtures/topic";
import { cloneJSON } from "discourse-common/lib/object";
@ -355,7 +354,9 @@ acceptance("Topic featured links", function (needs) {
assert.ok(!exists(".gap"), "it hides gap");
});
test("Quoting a quote keeps the original poster name", async function (assert) {
// quote related skip tests were chromeTest before
skip("Quoting a quote keeps the original poster name", async function (assert) {
await visit("/t/internationalization-localization/280");
await selectText("#post_5 blockquote");
await click(".quote-button .insert-quote");
@ -367,7 +368,7 @@ acceptance("Topic featured links", function (needs) {
);
});
test("Quoting a quote of a different topic keeps the original topic title", async function (assert) {
skip("Quoting a quote of a different topic keeps the original topic title", async function (assert) {
await visit("/t/internationalization-localization/280");
await selectText("#post_9 blockquote");
await click(".quote-button .insert-quote");
@ -381,7 +382,7 @@ acceptance("Topic featured links", function (needs) {
);
});
test("Quoting a quote with the Reply button keeps the original poster name", async function (assert) {
skip("Quoting a quote with the Reply button keeps the original poster name", async function (assert) {
await visit("/t/internationalization-localization/280");
await selectText("#post_5 blockquote");
await click(".reply");
@ -394,21 +395,18 @@ acceptance("Topic featured links", function (needs) {
});
// Using J/K on Firefox clean the text selection, so this won't work there
chromeTest(
"Quoting a quote with replyAsNewTopic keeps the original poster name",
async function (assert) {
await visit("/t/internationalization-localization/280");
await selectText("#post_5 blockquote");
await triggerKeyEvent(document, "keypress", "j".charCodeAt(0));
await triggerKeyEvent(document, "keypress", "t".charCodeAt(0));
skip("Quoting a quote with replyAsNewTopic keeps the original poster name", async function (assert) {
await visit("/t/internationalization-localization/280");
await selectText("#post_5 blockquote");
await triggerKeyEvent(document, "keypress", "j".charCodeAt(0));
await triggerKeyEvent(document, "keypress", "t".charCodeAt(0));
assert.ok(
queryAll(".d-editor-input")
.val()
.indexOf('quote="codinghorror said, post:3, topic:280"') !== -1
);
}
);
assert.ok(
queryAll(".d-editor-input")
.val()
.indexOf('quote="codinghorror said, post:3, topic:280"') !== -1
);
});
test("Quoting by selecting text can mark the quote as full", async function (assert) {
await visit("/t/internationalization-localization/280");

4
app/assets/javascripts/discourse/tests/acceptance/unknown-test.js
View File

@ -1,6 +1,6 @@
import { acceptance, exists } from "discourse/tests/helpers/qunit-helpers";
import { click, currentURL, visit } from "@ember/test-helpers";
import { test } from "qunit";
import { skip, test } from "qunit";
acceptance("Category 404", function (needs) {
needs.pretender((server, helper) => {
@ -12,7 +12,7 @@ acceptance("Category 404", function (needs) {
});
});
});
test("Navigating to a bad category link does not break the router", async function (assert) {
skip("Navigating to a bad category link does not break the router", async function (assert) {
await visit("/t/internationalization-localization/280");
await click('[data-for-test="category-404"]');