Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Skip flakey network disconnected spec (#23087)

This commit is contained in:
Mark VanLandingham 2023-08-14 12:24:16 -05:00 committed by GitHub
parent 61571bee43
commit bd7a10d705
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
spec/system/network_disconnected_spec.rb
View File

@ -11,19 +11,24 @@ RSpec.describe "Network Disconnected", type: :system do
end end
it "NetworkConnectivity service adds class to DOM and displays offline indicator" do it "NetworkConnectivity service adds class to DOM and displays offline indicator" do
SiteSetting.enable_offline_indicator = true skip(<<~TEXT)
# In CI this test will randomly flake - timing issue with the offline indicator
# not being rendered soon enough after network conditions change
visit("/c") SiteSetting.enable_offline_indicator = true
expect(page).to have_no_css("html.network-disconnected") visit("/c")
expect(page).to have_no_css(".offline-indicator")
with_network_disconnected do expect(page).to have_no_css("html.network-disconnected")
# Message bus connectivity services adds the disconnected class to the DOM expect(page).to have_no_css(".offline-indicator")
expect(page).to have_css("html.network-disconnected")
# Offline indicator is rendered with_network_disconnected doskip(<<~TEXT)
expect(page).to have_css(".offline-indicator") # Message bus connectivity services adds the disconnected class to the DOM
end expect(page).to have_css("html.network-disconnected")
# Offline indicator is rendered
expect(page).to have_css(".offline-indicator")
end
TEXT
end end
end end