PERF: N+1 query when saving a user.

2017-01-27 10:53:42 +08:00 · 2017-01-27 10:53:42 +08:00 · c01cee4aa6
parent 156a00af47
commit c01cee4aa6
1 changed files with 2 additions and 1 deletions
--- a/app/models/user.rb
+++ b/app/models/user.rb
@ -933,12 +933,13 @@ class User < ActiveRecord::Base
  end

  def automatic_group_membership
+    user = User.find(self.id)
+
    Group.where(automatic: false)
         .where("LENGTH(COALESCE(automatic_membership_email_domains, '')) > 0")
         .each do |group|

      domains = group.automatic_membership_email_domains.gsub('.', '\.')
-      user = User.find(self.id)

      if user.reload.email =~ Regexp.new("@(#{domains})$", true) && !group.users.include?(user)
        group.add(user)