From c1a01b2a28aed3f0199213c9622220a6ec063b04 Mon Sep 17 00:00:00 2001
From: Sam <sam.saffron@gmail.com>
Date: Tue, 19 Jul 2016 10:55:35 +1000
Subject: [PATCH] PERF: limit maximum number of topic links to 50

When a giant topic has huge numbers of links only show top 50
if expanded from the show more links... button.
---
 app/models/topic_link.rb     | 31 +++++++++++++++++--------------
 config/locales/client.en.yml |  2 +-
 2 files changed, 18 insertions(+), 15 deletions(-)

diff --git a/app/models/topic_link.rb b/app/models/topic_link.rb
index 2f7cc745236..182c3d64d91 100644
--- a/app/models/topic_link.rb
+++ b/app/models/topic_link.rb
@@ -37,20 +37,23 @@ class TopicLink < ActiveRecord::Base
   def self.topic_map(guardian, topic_id)
 
     # Sam: complicated reports are really hard in AR
-    builder = SqlBuilder.new("SELECT ftl.url,
-                     COALESCE(ft.title, ftl.title) AS title,
-                     ftl.link_topic_id,
-                     ftl.reflection,
-                     ftl.internal,
-                     ftl.domain,
-                     MIN(ftl.user_id) AS user_id,
-                     SUM(clicks) AS clicks
-              FROM topic_links AS ftl
-              LEFT JOIN topics AS ft ON ftl.link_topic_id = ft.id
-              LEFT JOIN categories AS c ON c.id = ft.category_id
-              /*where*/
-              GROUP BY ftl.url, ft.title, ftl.title, ftl.link_topic_id, ftl.reflection, ftl.internal, ftl.domain
-              ORDER BY clicks DESC")
+    builder = SqlBuilder.new <<SQL
+  SELECT ftl.url,
+         COALESCE(ft.title, ftl.title) AS title,
+         ftl.link_topic_id,
+         ftl.reflection,
+         ftl.internal,
+         ftl.domain,
+         MIN(ftl.user_id) AS user_id,
+         SUM(clicks) AS clicks
+  FROM topic_links AS ftl
+  LEFT JOIN topics AS ft ON ftl.link_topic_id = ft.id
+  LEFT JOIN categories AS c ON c.id = ft.category_id
+  /*where*/
+  GROUP BY ftl.url, ft.title, ftl.title, ftl.link_topic_id, ftl.reflection, ftl.internal, ftl.domain
+  ORDER BY clicks DESC, count(*) DESC
+  LIMIT 50
+SQL
 
     builder.where('ftl.topic_id = :topic_id', topic_id: topic_id)
     builder.where('ft.deleted_at IS NULL')
diff --git a/config/locales/client.en.yml b/config/locales/client.en.yml
index 0b240127633..3cb67e0c85d 100644
--- a/config/locales/client.en.yml
+++ b/config/locales/client.en.yml
@@ -1868,7 +1868,7 @@ en:
       title: "Topic Summary"
       participants_title: "Frequent Posters"
       links_title: "Popular Links"
-      links_shown: "show all {{totalLinks}} links..."
+      links_shown: "show more links..."
       clicks:
         one: "1 click"
         other: "%{count} clicks"