Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: add support for style element in SVGs

This commit is contained in:
Régis Hanol 2019-02-07 12:09:06 +01:00
parent 0c14f0d0a0
commit c256121833
3 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/upload_creator.rb
View File

@ -9,7 +9,7 @@ class UploadCreator
WHITELISTED_SVG_ELEMENTS ||= %w{ WHITELISTED_SVG_ELEMENTS ||= %w{
circle clippath defs ellipse g line linearGradient path polygon polyline circle clippath defs ellipse g line linearGradient path polygon polyline
radialGradient rect stop svg text textpath tref tspan use radialGradient rect stop style svg text textpath tref tspan use
}.each(&:freeze) }.each(&:freeze)
# Available options # Available options

5
spec/fixtures/images/image.svg vendored
View File

@ -1,3 +1,6 @@
<svg width="100" height="50"> <svg width="100" height="50">
<text x="25" y="25">Discourse</text> <style>
.black { fill: #FFFFFF; }
</style>
<text class="black" x="25" y="25">Discourse</text>
</svg> </svg>

Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 76 B

After

Width:  |  Height:  |  Size: 141 B

10
spec/models/upload_spec.rb
View File

@ -45,6 +45,16 @@ describe Upload do
end end
end end
it "supports <style> element in SVG" do
SiteSetting.authorized_extensions = "svg"
upload = UploadCreator.new(image_svg, image_svg_filename).create_for(user_id)
expect(upload.valid?).to eq(true)
path = Discourse.store.path_for(upload)
expect(File.read(path)).to match(/<style>/)
end
it "can reconstruct dimensions on demand" do it "can reconstruct dimensions on demand" do
upload = UploadCreator.new(huge_image, "image.png").create_for(user_id) upload = UploadCreator.new(huge_image, "image.png").create_for(user_id)