Merge pull request #1439 from zvikara/master

HandlebarsOneboxes: avoid constants multiple declarations

lib/oneboxer/stack_exchange_onebox.rb

@@ -2,17 +2,21 @@ require_dependency 'oneboxer/handlebars_onebox'
 
 module Oneboxer
   class StackExchangeOnebox < HandlebarsOnebox
-    DOMAINS = [
+
-      'stackexchange',
+    unless defined? DOMAINS
-      'stackoverflow',
+      DOMAINS = [
-      'superuser',
+        'stackexchange',
-      'serverfault',
+        'stackoverflow',
-      'askubuntu'
+        'superuser',
-    ]
+        'serverfault',
+        'askubuntu'
+      ]
+    end
 
     # http://rubular.com/r/V3T0I1VTPn
-    REGEX =
+    unless defined? REGEX
-      /^http:\/\/(?:(?:(?<subsubdomain>\w*)\.)?(?<subdomain>\w*)\.)?(?<domain>#{DOMAINS.join('|')})\.com\/(?:questions|q)\/(?<question>\d*)/
+      REGEX = /^http:\/\/(?:(?:(?<subsubdomain>\w*)\.)?(?<subdomain>\w*)\.)?(?<domain>#{DOMAINS.join('|')})\.com\/(?:questions|q)\/(?<question>\d*)/
+    end
 
     matcher REGEX
     favicon 'stackexchange.png'

lib/oneboxer/twitter_onebox.rb

@@ -2,10 +2,14 @@ require_dependency 'oneboxer/handlebars_onebox'
 
 module Oneboxer
   class TwitterOnebox < HandlebarsOnebox
-    BASE_URL = 'https://api.twitter.com'.freeze
 
-    REGEX =
+    unless defined? BASE_URL
-      /^https?:\/\/(?:www\.)?twitter.com\/(?<user>[^\/]+)\/status\/(?<id>\d+)$/
+      BASE_URL = 'https://api.twitter.com'.freeze
+    end
+
+    unless defined? REGEX
+      REGEX = /^https?:\/\/(?:www\.)?twitter.com\/(?<user>[^\/]+)\/status\/(?<id>\d+)$/
+    end
 
     matcher REGEX