Merge pull request #1439 from zvikara/master
HandlebarsOneboxes: avoid constants multiple declarations
This commit is contained in:
commit
c2ceced747
|
@ -2,6 +2,8 @@ require_dependency 'oneboxer/handlebars_onebox'
|
|||
|
||||
module Oneboxer
|
||||
class StackExchangeOnebox < HandlebarsOnebox
|
||||
|
||||
unless defined? DOMAINS
|
||||
DOMAINS = [
|
||||
'stackexchange',
|
||||
'stackoverflow',
|
||||
|
@ -9,10 +11,12 @@ module Oneboxer
|
|||
'serverfault',
|
||||
'askubuntu'
|
||||
]
|
||||
end
|
||||
|
||||
# http://rubular.com/r/V3T0I1VTPn
|
||||
REGEX =
|
||||
/^http:\/\/(?:(?:(?<subsubdomain>\w*)\.)?(?<subdomain>\w*)\.)?(?<domain>#{DOMAINS.join('|')})\.com\/(?:questions|q)\/(?<question>\d*)/
|
||||
unless defined? REGEX
|
||||
REGEX = /^http:\/\/(?:(?:(?<subsubdomain>\w*)\.)?(?<subdomain>\w*)\.)?(?<domain>#{DOMAINS.join('|')})\.com\/(?:questions|q)\/(?<question>\d*)/
|
||||
end
|
||||
|
||||
matcher REGEX
|
||||
favicon 'stackexchange.png'
|
||||
|
|
|
@ -2,10 +2,14 @@ require_dependency 'oneboxer/handlebars_onebox'
|
|||
|
||||
module Oneboxer
|
||||
class TwitterOnebox < HandlebarsOnebox
|
||||
BASE_URL = 'https://api.twitter.com'.freeze
|
||||
|
||||
REGEX =
|
||||
/^https?:\/\/(?:www\.)?twitter.com\/(?<user>[^\/]+)\/status\/(?<id>\d+)$/
|
||||
unless defined? BASE_URL
|
||||
BASE_URL = 'https://api.twitter.com'.freeze
|
||||
end
|
||||
|
||||
unless defined? REGEX
|
||||
REGEX = /^https?:\/\/(?:www\.)?twitter.com\/(?<user>[^\/]+)\/status\/(?<id>\d+)$/
|
||||
end
|
||||
|
||||
matcher REGEX
|
||||
|
||||
|
|
Loading…
Reference in New Issue