Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: Disable image optimization in iOS Safari (#19790) 

There are various performance issues with the Canvas in iOS Safari
that are causing crashes when processing images with spikes of over 100%
CPU usage. The cause of this is unknown, but profiling points to
CanvasRenderingContext2D.getImageData() and
CanvasRenderingContext2D.drawImage().

Until Safari makes some progress with OffscreenCanvas or other
alternatives we cannot support this workflow. We will revisit in 6
months.

This is gated behind the hidden `composer_ios_media_optimisation_image_enabled`
site setting for people who really still want to try using this.
This commit is contained in:
Martin Brennan 2023-01-09 12:16:02 +10:00 committed by GitHub
parent 673089a6b4
commit c31772879b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 24 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
app/assets/javascripts/discourse/app/initializers/register-media-optimization-upload-processor.js
View File

@ -6,8 +6,27 @@ export default {
name: "register-media-optimization-upload-processor",
initialize(container) {
let siteSettings = container.lookup("service:site-settings");
const siteSettings = container.lookup("service:site-settings");
const capabilities = container.lookup("capabilities:main");
if (siteSettings.composer_media_optimization_image_enabled) {
// NOTE: There are various performance issues with the Canvas
// in iOS Safari that are causing crashes when processing images
// with spikes of over 100% CPU usage. The cause of this is unknown,
// but profiling points to CanvasRenderingContext2D.getImageData()
// and CanvasRenderingContext2D.drawImage().
//
// Until Safari makes some progress with OffscreenCanvas or other
// alternatives we cannot support this workflow.
//
// TODO (martin): Revisit around 2022-06-01 to see the state of iOS Safari.
if (
capabilities.isIOS &&
!siteSettings.composer_ios_media_optimisation_image_enabled
) {
return;
}
addComposerUploadPreProcessor(
UppyMediaOptimization,
({ isMobileDevice }) => {

4
config/site_settings.yml
View File

@ -1549,6 +1549,10 @@ files:
default: false
client: true
hidden: true
composer_ios_media_optimisation_image_enabled:
default: false
client: true
hidden: true
trust:
default_trust_level: