Discource-C/discourse
1
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-06 03:18:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add comments to relevant sections denoting "create new topic" scenario is not supported for cannot-see-mention (per @coding-horror instruction)

Browse Source
This commit is contained in:
cpradio 2016-11-16 06:26:36 -05:00
parent a6b86036ca
commit c3d4c949f1
3 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/discourse/components/composer-editor.js.es6
View File

@ -137,6 +137,8 @@ export default Ember.Component.extend({
},
_renderUnseenMentions($preview, unseen) {
// 'Create a New Topic' scenario is not supported (per conversation with codinghorror)
// https://meta.discourse.org/t/taking-another-1-7-release-task/51986/7
fetchUnseenMentions(unseen, this.get('topic.id')).then(() => {
linkSeenMentions($preview, this.siteSettings);
this._warnMentionedGroups($preview);

2
app/assets/javascripts/discourse/lib/link-mentions.js.es6
View File

@ -51,6 +51,8 @@ export function linkSeenMentions($elem, siteSettings) {
return [];
}
// 'Create a New Topic' scenario is not supported (per conversation with codinghorror)
// https://meta.discourse.org/t/taking-another-1-7-release-task/51986/7
export function fetchUnseenMentions(usernames, topic_id) {
return ajax("/users/is_local_username", { data: { usernames, topic_id } }).then(r => {
r.valid.forEach(v => found[v] = true);

2
app/controllers/users_controller.rb
View File

@ -242,6 +242,8 @@ class UsersController < ApplicationController
usernames -= groups
usernames.each(&:downcase!)
# Create a New Topic Scenario is not supported (per conversation with codinghorror)
# https://meta.discourse.org/t/taking-another-1-7-release-task/51986/7
cannot_see = []
topic_id = params[:topic_id]
unless topic_id.blank?