DEV: Remove handlebars from the old package.json (#17319)

lib/freedom_patches/raw_handlebars.rb

@@ -4,7 +4,7 @@
 
 class Barber::Precompiler
   def sources
-    [File.open("#{Rails.root}/vendor/assets/javascripts/handlebars.js"),
+    [File.open("#{Rails.root}/app/assets/javascripts/node_modules/handlebars/dist/handlebars.js"),
      precompiler]
   end
 

lib/tasks/javascript.rake

@@ -86,10 +86,6 @@ def dependencies
     }, {
       source: 'pikaday/pikaday.js',
       public: true
-    }, {
-      source: 'handlebars/dist/handlebars.js'
-    }, {
-      source: 'handlebars/dist/handlebars.runtime.js'
     }, {
       source: '@highlightjs/cdn-assets/.',
       destination: 'highlightjs'

package.json

@@ -16,7 +16,6 @@
     "chartjs-plugin-datalabels": "^2.0.0",
     "diffhtml": "^1.0.0-beta.20",
     "eslint-config-discourse": "^2.0.0",
-    "handlebars": "^4.7.7",
     "magnific-popup": "1.1.0",
     "markdown-it": "13.0.1",
     "moment": "2.29.2",

spec/lib/theme_javascript_compiler_spec.rb

@@ -28,7 +28,7 @@ describe ThemeJavascriptCompiler do
 
     let(:mini_racer) {
       ctx = MiniRacer::Context.new
-      ctx.eval(File.open("#{Rails.root}/vendor/assets/javascripts/handlebars.js").read)
+      ctx.eval(File.open("#{Rails.root}/app/assets/javascripts/node_modules/handlebars/dist/handlebars.js").read)
       ctx.eval(helpers)
       ctx
     }

yarn.lock

@@ -1079,7 +1079,7 @@ globby@^11.0.1:
     merge2 "^1.3.0"
     slash "^3.0.0"
 
-handlebars@^4.7.4, handlebars@^4.7.7:
+handlebars@^4.7.4:
   version "4.7.7"
   resolved "https://registry.yarnpkg.com/handlebars/-/handlebars-4.7.7.tgz#9ce33416aad02dbd6c8fafa8240d5d98004945a1"
   integrity sha512-aAcXm5OAfE/8IXkcZvCepKU3VzW1/39Fb5ZuqMtgI/hT8X2YgoMvBY5dLhq/cpOvw7Lk1nK/UF71aLG/ZnVYRA==