From c62f0827546c59d77dd6860d220378577059333c Mon Sep 17 00:00:00 2001
From: David Taylor <david@taylorhq.com>
Date: Tue, 17 Nov 2020 15:59:55 +0000
Subject: [PATCH] UX: Only link the icon for site setting history (#11265)

Linking the whole site setting name makes it tricky to copy/paste the name, which is common when asking/answering support queries.
---
 .../templates/components/site-setting.hbs     |  2 +-
 .../stylesheets/common/admin/settings.scss    | 19 +++++++------------
 2 files changed, 8 insertions(+), 13 deletions(-)

diff --git a/app/assets/javascripts/admin/addon/templates/components/site-setting.hbs b/app/assets/javascripts/admin/addon/templates/components/site-setting.hbs
index cf6d07a6db9..b7029ebe022 100644
--- a/app/assets/javascripts/admin/addon/templates/components/site-setting.hbs
+++ b/app/assets/javascripts/admin/addon/templates/components/site-setting.hbs
@@ -1,8 +1,8 @@
 <div class="setting-label">
   <h3>
     {{#if staffLogFilter}}
+      {{settingName}}
       {{#link-to "adminLogs.staffActionLogs" (query-params filters=staffLogFilter) title=(i18n "admin.settings.history")}}
-        {{settingName}}
         <span class="history-icon">
           {{d-icon "history"}}
         </span>
diff --git a/app/assets/stylesheets/common/admin/settings.scss b/app/assets/stylesheets/common/admin/settings.scss
index 0561a2cd09f..6fb4134d8aa 100644
--- a/app/assets/stylesheets/common/admin/settings.scss
+++ b/app/assets/stylesheets/common/admin/settings.scss
@@ -15,18 +15,13 @@
           margin-bottom: 6px;
         }
       }
-      h3 {
-        a:any-link {
-          color: unset;
-        }
-        .history-icon {
-          opacity: 0;
-          transition: opacity 0.3s;
-          color: var(--primary-medium);
-        }
-        &:hover .history-icon {
-          opacity: 1;
-        }
+      .history-icon {
+        opacity: 0;
+        transition: opacity 0.3s;
+        color: var(--primary-medium);
+      }
+      &:hover .history-icon {
+        opacity: 1;
       }
     }
     .setting-value {