Discource-C/discourse
1
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-16 16:24:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

A11Y: Keep composer as focused element when dismissing Link modal via keyboard (#17893)

Browse Source
This commit is contained in:
Penar Musaraj 2022-08-14 21:37:19 -04:00 committed by GitHub
parent a32019d1e7
commit c66d544cf9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/assets/javascripts/discourse/app/controllers/insert-hyperlink.js
View File

@ -58,6 +58,7 @@ export default Controller.extend(ModalFunctionality, {
event.stopPropagation();
} else {
this.send("closeModal");
document.querySelector(".d-editor-input")?.focus();
}
break;
}

8
app/assets/javascripts/discourse/tests/acceptance/composer-hyperlink-test.js
View File

@ -98,5 +98,13 @@ acceptance("Composer - Hyperlink", function (needs) {
query(".link-url").value.includes("http"),
"replaces link url field with internal link"
);
await triggerKeyEvent(".insert-link", "keydown", "Escape");
assert.strictEqual(
document.activeElement.classList.contains("d-editor-input"),
true,
"focus stays on composer after dismissing modal using Esc key"
);
});
});