Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: prevent chat channel not found ajax error (#28818) 

On occasion we get an error popup on desktop due to the channel not being found.

This change means that we only check the cached channels in ChatChannelsManager for the matching channel id, but we skip doing manual lookup which results in ajax popup when it fails.
This commit is contained in:
David Battersby 2024-09-10 11:52:25 +04:00 committed by GitHub
parent f86e6b8d63
commit c697e70892
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
plugins/chat/assets/javascripts/discourse/services/chat-notification-manager.js
View File

@ -148,7 +148,9 @@ export default class ChatNotificationManager extends Service {
@action
async fetchChannel(channelId) {
return await this.chatChannelsManager.find(channelId);
return await this.chatChannelsManager.find(channelId, {
fetchIfNotFound: false,
});
}
@bind
@ -159,7 +161,10 @@ export default class ChatNotificationManager extends Service {
if (this.site.desktopView) {
const channel = await this.fetchChannel(data.channel_id);
data.isDirectMessageChannel = channel.isDirectMessageChannel ?? false;
if (channel) {
data.isDirectMessageChannel = channel.isDirectMessageChannel ?? false;
}
return onDesktopNotification(
data,