From c6fe082fe4170e24f62a363fb90d62a277675504 Mon Sep 17 00:00:00 2001 From: OsamaSayegh Date: Mon, 11 Jun 2018 07:32:55 +0300 Subject: [PATCH] REFACTOR: admin controller specs to requests (#5978) --- .../admin/admin_controller_spec.rb | 20 ------------------- spec/requests/admin/admin_controller_spec.rb | 18 ++++++++++++----- 2 files changed, 13 insertions(+), 25 deletions(-) delete mode 100644 spec/controllers/admin/admin_controller_spec.rb diff --git a/spec/controllers/admin/admin_controller_spec.rb b/spec/controllers/admin/admin_controller_spec.rb deleted file mode 100644 index f26b081a9d2..00000000000 --- a/spec/controllers/admin/admin_controller_spec.rb +++ /dev/null @@ -1,20 +0,0 @@ -require 'rails_helper' - -describe Admin::AdminController do - - context 'index' do - - it 'needs you to be logged in' do - get :index, format: :json - expect(response.status).to eq(403) - end - - it "raises an error if you aren't an admin" do - _user = log_in - get :index, format: :json - expect(response).to be_forbidden - end - - end - -end diff --git a/spec/requests/admin/admin_controller_spec.rb b/spec/requests/admin/admin_controller_spec.rb index c479ada153b..062f3a3a0e5 100644 --- a/spec/requests/admin/admin_controller_spec.rb +++ b/spec/requests/admin/admin_controller_spec.rb @@ -1,11 +1,19 @@ require 'rails_helper' RSpec.describe Admin::AdminController do - it "should return the right response if user isn't a staff" do - get "/admin", params: { api_key: 'asdiasiduga' } - expect(response.status).to eq(404) + describe '#index' do + it "needs you to be logged in" do + get "/admin.json" + expect(response.status).to eq(404) + end - get "/admin" - expect(response.status).to eq(404) + it "should return the right response if user isn't a staff" do + sign_in(Fabricate(:user)) + get "/admin", params: { api_key: 'asdiasiduga' } + expect(response.status).to eq(404) + + get "/admin" + expect(response.status).to eq(404) + end end end