Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: closed polls with no votes showed NaN as percentage and average

This commit is contained in:
Gerhard Schlager 2015-05-02 01:58:23 +02:00
parent 2ead293098
commit c9e4fd578d
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
plugins/poll/assets/javascripts/components/poll-results-number.js.es6
View File

@ -12,7 +12,8 @@ export default Em.Component.extend({
}.property("poll.options.@each.{html,votes}"), }.property("poll.options.@each.{html,votes}"),
average: function() { average: function() {
return round(this.get("totalScore") / this.get("poll.total_votes"), -2); const total_votes = this.get("poll.total_votes");
return total_votes == 0 ? 0 : round(this.get("totalScore") / total_votes, -2);
}.property("totalScore", "poll.total_votes"), }.property("totalScore", "poll.total_votes"),
averageRating: function() { averageRating: function() {

2
plugins/poll/assets/javascripts/components/poll-results-standard.js.es6
View File

@ -7,7 +7,7 @@ export default Em.Component.extend({
backgroundColor = this.get("poll.background"); backgroundColor = this.get("poll.background");
this.get("poll.options").forEach(option => { this.get("poll.options").forEach(option => {
const percentage = Math.floor(100 * option.get("votes") / totalVotes), const percentage = totalVotes == 0 ? 0 : Math.floor(100 * option.get("votes") / totalVotes),
styles = ["width: " + percentage + "%"]; styles = ["width: " + percentage + "%"];
if (backgroundColor) { styles.push("background: " + backgroundColor); } if (backgroundColor) { styles.push("background: " + backgroundColor); }