UX: Hide pending score statuses

This commit is contained in:
Robin Ward 2019-05-22 11:26:01 -04:00
parent cf63a9bb53
commit ca03baf2b2
2 changed files with 27 additions and 21 deletions

View File

@ -17,29 +17,33 @@
{{format-date rs.created_at format="tiny"}}
</td>
<td class="reviewable-score-spacer">
{{d-icon "angle-double-right"}}
</td>
{{#if showStatus}}
<td class="reviewable-score-spacer">
{{d-icon "angle-double-right"}}
</td>
<td class='reviewed-by'>
{{#if rs.reviewed_by}}
{{#user-link user=rs.reviewed_by}}
{{avatar rs.reviewed_by imageSize="tiny"}}
{{rs.reviewed_by.username}}
{{/user-link}}
{{else}}
&mdash;
{{/if}}
</td>
<td class='reviewed-by'>
{{#if rs.reviewed_by}}
{{#user-link user=rs.reviewed_by}}
{{avatar rs.reviewed_by imageSize="tiny"}}
{{rs.reviewed_by.username}}
{{/user-link}}
{{else}}
&mdash;
{{/if}}
</td>
<td>
{{reviewable-status rs.status}}
</td>
<td>
{{#if rs.reviewed_by}}
{{format-date rs.reviewed_at format="tiny"}}
{{/if}}
</td>
<td>
{{reviewable-status rs.status}}
</td>
<td>
{{#if rs.reviewed_by}}
{{format-date rs.reviewed_at format="tiny"}}
{{/if}}
</td>
{{else}}
<td colspan="4"></td>
{{/if}}
</tr>
{{#if rs.reason}}

View File

@ -3,6 +3,8 @@ import computed from "ember-addons/ember-computed-decorators";
export default Ember.Component.extend({
tagName: "",
showStatus: Ember.computed.gt("rs.status", 0),
@computed("rs.score_type.title", "reviewable.target_created_by")
title(title, targetCreatedBy) {
if (title && targetCreatedBy) {