UX: Hide pending score statuses

This commit is contained in:
Robin Ward 2019-05-22 11:26:01 -04:00
parent cf63a9bb53
commit ca03baf2b2
2 changed files with 27 additions and 21 deletions

View File

@ -17,29 +17,33 @@
{{format-date rs.created_at format="tiny"}} {{format-date rs.created_at format="tiny"}}
</td> </td>
<td class="reviewable-score-spacer"> {{#if showStatus}}
{{d-icon "angle-double-right"}} <td class="reviewable-score-spacer">
</td> {{d-icon "angle-double-right"}}
</td>
<td class='reviewed-by'> <td class='reviewed-by'>
{{#if rs.reviewed_by}} {{#if rs.reviewed_by}}
{{#user-link user=rs.reviewed_by}} {{#user-link user=rs.reviewed_by}}
{{avatar rs.reviewed_by imageSize="tiny"}} {{avatar rs.reviewed_by imageSize="tiny"}}
{{rs.reviewed_by.username}} {{rs.reviewed_by.username}}
{{/user-link}} {{/user-link}}
{{else}} {{else}}
&mdash; &mdash;
{{/if}} {{/if}}
</td> </td>
<td> <td>
{{reviewable-status rs.status}} {{reviewable-status rs.status}}
</td> </td>
<td> <td>
{{#if rs.reviewed_by}} {{#if rs.reviewed_by}}
{{format-date rs.reviewed_at format="tiny"}} {{format-date rs.reviewed_at format="tiny"}}
{{/if}} {{/if}}
</td> </td>
{{else}}
<td colspan="4"></td>
{{/if}}
</tr> </tr>
{{#if rs.reason}} {{#if rs.reason}}

View File

@ -3,6 +3,8 @@ import computed from "ember-addons/ember-computed-decorators";
export default Ember.Component.extend({ export default Ember.Component.extend({
tagName: "", tagName: "",
showStatus: Ember.computed.gt("rs.status", 0),
@computed("rs.score_type.title", "reviewable.target_created_by") @computed("rs.score_type.title", "reviewable.target_created_by")
title(title, targetCreatedBy) { title(title, targetCreatedBy) {
if (title && targetCreatedBy) { if (title && targetCreatedBy) {