FEATURE: Batch process topic bulk actions (#10980)

Topics are processed in chunks of 30 in order to prevent timeouts.
This commit is contained in:
Gerhard Schlager 2020-10-30 02:02:35 +01:00 committed by GitHub
parent ec35b353a7
commit cc74c3f9ab
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 62 additions and 9 deletions

View File

@ -5,6 +5,7 @@ import ModalFunctionality from "discourse/mixins/modal-functionality";
import Topic from "discourse/models/topic"; import Topic from "discourse/models/topic";
import Category from "discourse/models/category"; import Category from "discourse/models/category";
import bootbox from "bootbox"; import bootbox from "bootbox";
import { Promise } from "rsvp";
const _buttons = []; const _buttons = [];
@ -84,6 +85,7 @@ export default Controller.extend(ModalFunctionality, {
emptyTags: empty("tags"), emptyTags: empty("tags"),
categoryId: alias("model.category.id"), categoryId: alias("model.category.id"),
processedTopicCount: 0,
onShow() { onShow() {
const topics = this.get("model.topics"); const topics = this.get("model.topics");
@ -101,23 +103,70 @@ export default Controller.extend(ModalFunctionality, {
}, },
perform(operation) { perform(operation) {
this.set("processedTopicCount", 0);
this.send("changeBulkTemplate", "modal/bulk-progress");
this.set("loading", true); this.set("loading", true);
const topics = this.get("model.topics"); return this._processChunks(operation)
return Topic.bulkOperation(topics, operation)
.then((result) => {
this.set("loading", false);
if (result && result.topic_ids) {
return result.topic_ids.map((t) => topics.findBy("id", t));
}
return result;
})
.catch(() => { .catch(() => {
bootbox.alert(I18n.t("generic_error")); bootbox.alert(I18n.t("generic_error"));
})
.finally(() => {
this.set("loading", false); this.set("loading", false);
}); });
}, },
_generateTopicChunks(allTopics) {
let startIndex = 0;
const chunkSize = 30;
const chunks = [];
while (startIndex < allTopics.length) {
let topics = allTopics.slice(startIndex, startIndex + chunkSize);
chunks.push(topics);
startIndex += chunkSize;
}
return chunks;
},
_processChunks(operation) {
const allTopics = this.get("model.topics");
const topicChunks = this._generateTopicChunks(allTopics);
const topicIds = [];
const tasks = topicChunks.map((topics) => () => {
return Topic.bulkOperation(topics, operation).then((result) => {
this.set(
"processedTopicCount",
this.get("processedTopicCount") + topics.length
);
return result;
});
});
return new Promise((resolve, reject) => {
const resolveNextTask = () => {
if (tasks.length === 0) {
const topics = topicIds.map((id) => allTopics.findBy("id", id));
return resolve(topics);
}
tasks
.shift()()
.then((result) => {
if (result && result.topic_ids) {
topicIds.push(...result.topic_ids);
}
resolveNextTask();
})
.catch(reject);
};
resolveNextTask();
});
},
forEachPerformed(operation, cb) { forEachPerformed(operation, cb) {
this.perform(operation).then((topics) => { this.perform(operation).then((topics) => {
if (topics) { if (topics) {

View File

@ -0,0 +1 @@
<p>{{html-safe (i18n "topics.bulk.progress" count=processedTopicCount)}}</p>

View File

@ -2199,6 +2199,9 @@ en:
choose_append_tags: "Choose new tags to append for these topics:" choose_append_tags: "Choose new tags to append for these topics:"
changed_tags: "The tags of those topics were changed." changed_tags: "The tags of those topics were changed."
remove_tags: "Remove Tags" remove_tags: "Remove Tags"
progress:
one: "Progress: <strong>%{count}</strong> topic"
other: "Progress: <strong>%{count}</strong> topics"
none: none:
unread: "You have no unread topics." unread: "You have no unread topics."