From c978eade564da3c2186a20add07572ecb3041338 Mon Sep 17 00:00:00 2001 From: riking Date: Sun, 23 Mar 2014 21:59:13 -0700 Subject: [PATCH 1/2] Make Facebook login popup taller --- app/assets/javascripts/discourse/models/login_method.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/assets/javascripts/discourse/models/login_method.js b/app/assets/javascripts/discourse/models/login_method.js index 2209bbe1203..7f96fb12f09 100644 --- a/app/assets/javascripts/discourse/models/login_method.js +++ b/app/assets/javascripts/discourse/models/login_method.js @@ -37,13 +37,15 @@ Discourse.LoginMethod.reopenClass({ "yahoo", "github" ].forEach(function(name){ - if(Discourse.SiteSettings["enable_" + name + "_logins"]){ + if (Discourse.SiteSettings["enable_" + name + "_logins"]) { var params = {name: name}; - if(name === "google") { + if (name === "google") { params.frameWidth = 850; params.frameHeight = 500; + } else if (name === "facebook") { + params.frameHeight = 420; } methods.pushObject(Discourse.LoginMethod.create(params)); From 473201c9a47291ef4c8f6314df08af71c8ef8369 Mon Sep 17 00:00:00 2001 From: Kane York Date: Mon, 24 Mar 2014 20:02:04 -0700 Subject: [PATCH 2/2] Change specified height to 450 --- app/assets/javascripts/discourse/models/login_method.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/assets/javascripts/discourse/models/login_method.js b/app/assets/javascripts/discourse/models/login_method.js index 7f96fb12f09..3a7aabd8c6f 100644 --- a/app/assets/javascripts/discourse/models/login_method.js +++ b/app/assets/javascripts/discourse/models/login_method.js @@ -45,7 +45,7 @@ Discourse.LoginMethod.reopenClass({ params.frameWidth = 850; params.frameHeight = 500; } else if (name === "facebook") { - params.frameHeight = 420; + params.frameHeight = 450; } methods.pushObject(Discourse.LoginMethod.create(params));