From ce1fe8c8c23198c58b324da55d7294492f858648 Mon Sep 17 00:00:00 2001 From: Jeff Atwood Date: Mon, 11 May 2015 16:09:46 -0700 Subject: [PATCH] remove topic list striping, use bottom border --- .../stylesheets/common/base/_topic-list.scss | 8 ++------ app/assets/stylesheets/desktop/topic-list.scss | 7 +------ app/assets/stylesheets/desktop/topic-post.scss | 9 --------- app/assets/stylesheets/desktop/user.scss | 8 -------- app/assets/stylesheets/mobile/topic-list.scss | 8 +------- app/assets/stylesheets/mobile/user.scss | 16 ++++------------ 6 files changed, 8 insertions(+), 48 deletions(-) diff --git a/app/assets/stylesheets/common/base/_topic-list.scss b/app/assets/stylesheets/common/base/_topic-list.scss index 227e13a3539..a27fb1059de 100644 --- a/app/assets/stylesheets/common/base/_topic-list.scss +++ b/app/assets/stylesheets/common/base/_topic-list.scss @@ -16,20 +16,16 @@ .topic-list { width: 100%; - border-collapse: separate; - border-spacing: 0; + border-collapse: collapse; border-top: 1px solid dark-light-diff($primary, $secondary, 90%, -75%); background: rgba($secondary, .8); > tbody > tr { - - &.archived a { - opacity: 0.6; - } &.has-excerpt .star { vertical-align: top; margin-top: 2px; } + border-bottom: 1px solid dark-light-diff($primary, $secondary, 90%, -75%); } th, diff --git a/app/assets/stylesheets/desktop/topic-list.scss b/app/assets/stylesheets/desktop/topic-list.scss index 930fe7cdc4f..3f53b0d2ccd 100644 --- a/app/assets/stylesheets/desktop/topic-list.scss +++ b/app/assets/stylesheets/desktop/topic-list.scss @@ -55,12 +55,6 @@ } > tbody > tr { - &:nth-child(odd) { - background-color: darken($secondary, 3%); - } - &:nth-child(even) { - background-color: $secondary; - } &.highlighted { background-color: dark-light-diff($tertiary, $secondary, 90%, -41%); } @@ -184,6 +178,7 @@ position: relative; } > tbody > tr { + border-bottom: none; &:nth-child(odd) { background-color: darken($secondary, 3%); } diff --git a/app/assets/stylesheets/desktop/topic-post.scss b/app/assets/stylesheets/desktop/topic-post.scss index 901bdb96e33..b90acf03c3e 100644 --- a/app/assets/stylesheets/desktop/topic-post.scss +++ b/app/assets/stylesheets/desktop/topic-post.scss @@ -462,15 +462,6 @@ a.star { #suggested-topics { clear: left; padding: 20px 0 15px 0; - .topic-list { - > tbody > tr { - &:nth-child(odd) { - background-color: darken($secondary, 3%); - } - &:nth-child(even) { - background-color: $secondary; - } - } } table { table-layout: fixed; diff --git a/app/assets/stylesheets/desktop/user.scss b/app/assets/stylesheets/desktop/user.scss index 1ce508b649e..144308885b0 100644 --- a/app/assets/stylesheets/desktop/user.scss +++ b/app/assets/stylesheets/desktop/user.scss @@ -582,14 +582,6 @@ } .paginated-topics-list { - .topic-list > tbody > tr:nth-child(odd) { - background-color: darken($secondary, 3%); - } - - .topic-list > tbody > tr:nth-child(even) { - background-color: $secondary; - } - .user-content { width: 100%; margin-top: 0; diff --git a/app/assets/stylesheets/mobile/topic-list.scss b/app/assets/stylesheets/mobile/topic-list.scss index c37eabeea6b..15920f147ff 100644 --- a/app/assets/stylesheets/mobile/topic-list.scss +++ b/app/assets/stylesheets/mobile/topic-list.scss @@ -30,16 +30,10 @@ .topic-list { > tbody > tr { - &:nth-child(even) { - background-color: darken($secondary, 3%); - } - &:nth-child(odd) { - background-color: $secondary; - } &.highlighted { background-color: scale-color($tertiary, $lightness: 85%); } - } + } th, td { diff --git a/app/assets/stylesheets/mobile/user.scss b/app/assets/stylesheets/mobile/user.scss index b723606ffe6..f73c9acafd4 100644 --- a/app/assets/stylesheets/mobile/user.scss +++ b/app/assets/stylesheets/mobile/user.scss @@ -579,18 +579,10 @@ .paginated-topics-list { margin-top: 20px; - .topic-list > tbody > tr:nth-child(odd) { - background-color: darken($secondary, 3%); - } - - .topic-list > tbody > tr:nth-child(even) { - background-color: $secondary; - } - - .user-content { - width: 100%; - margin-top: 0; - } + .user-content { + width: 100%; + margin-top: 0; + } } .user-archive {