From cbaa8893ce75bfb60b6d49a5e8de8f1d3ea9810c Mon Sep 17 00:00:00 2001 From: vagrant Date: Fri, 31 Oct 2014 00:46:27 -0400 Subject: [PATCH 1/3] few small usercard fixes, more to come! --- .../discourse/templates/user-card.hbs | 18 +++++++++++++---- app/assets/stylesheets/desktop/user-card.scss | 20 +++++++++++++------ 2 files changed, 28 insertions(+), 10 deletions(-) diff --git a/app/assets/javascripts/discourse/templates/user-card.hbs b/app/assets/javascripts/discourse/templates/user-card.hbs index 62069b38db2..600c3702288 100644 --- a/app/assets/javascripts/discourse/templates/user-card.hbs +++ b/app/assets/javascripts/discourse/templates/user-card.hbs @@ -1,6 +1,6 @@ -{{#if username}} +
-
+{{#if username}} {{#link-to 'user' user}}{{bound-avatar avatar "huge"}}{{/link-to}} @@ -9,9 +9,19 @@

{{#link-to 'user' user}}{{username}}{{/link-to}}

- {{#if user.title}} -

{{user.title}}

+ + {{#if user.name}} +

{{user.name}}

{{/if}} + + {{#if user.title}} + {{#if user.name}} +

/ {{user.title}}

+ {{else}} +

{{user.title}}

+ {{/if}} + {{/if}} + {{#if showName}}

{{#link-to 'user' user}}{{name}}{{/link-to}}

{{/if}} diff --git a/app/assets/stylesheets/desktop/user-card.scss b/app/assets/stylesheets/desktop/user-card.scss index d03ec4eab47..175110b4a0a 100644 --- a/app/assets/stylesheets/desktop/user-card.scss +++ b/app/assets/stylesheets/desktop/user-card.scss @@ -11,11 +11,13 @@ color: $secondary; background-size: cover; background-position: center center; + min-height: 175px; .card-content { padding: 12px; background: rgba($primary, .85); - margin-top: 100px; + margin-top: 85px; + &:after { content: ''; display: block; @@ -24,6 +26,8 @@ } &.no-bg { + min-height: 50px; + .card-content { margin-top: 0; } @@ -60,6 +64,7 @@ white-space: nowrap; overflow: hidden; text-overflow: ellipsis; + display: inline; a { color: $secondary; } @@ -101,8 +106,8 @@ } .bio { - max-height: 55px; - overflow: auto; + max-height: 60px; + overflow: hidden; float: left; margin: 10px 0; width: 70%; @@ -161,6 +166,7 @@ position: absolute; bottom: 0; display: block; + width: 250px; } } @@ -186,7 +192,6 @@ .more-user-badges { @extend .user-badge; padding: 3px 8px; - font-size: 13px; } } @@ -199,7 +204,10 @@ img { max-width: 100px; } - float: right; - margin-right: 5px; + position: absolute; + right: 12px; + bottom: 12px; + font-size: 30px; + i {color: $secondary;} } } From 9ffd7546eb5d895043d92d624cf018963d41874c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9gis=20Hanol?= Date: Fri, 31 Oct 2014 12:01:16 +0100 Subject: [PATCH 2/3] add 'plugins' directory to sublime's project file --- discourse.sublime-project | 1 + 1 file changed, 1 insertion(+) diff --git a/discourse.sublime-project b/discourse.sublime-project index 16bc37e55d2..6ce1a8c6ea1 100644 --- a/discourse.sublime-project +++ b/discourse.sublime-project @@ -12,6 +12,7 @@ "file_exclude_patterns": ["*.sqlite3"] }, { "path": "lib" }, + { "path": "plugins" }, { "path": "script" }, { "path": "spec" }, { "path": "test", From 22525ff74c821a9c7da2ee9ba73ce2e974f1d63d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9gis=20Hanol?= Date: Fri, 31 Oct 2014 12:01:47 +0100 Subject: [PATCH 3/3] FIX: changing title of a poll should close/open the poll --- .../poll/assets/javascripts/initializers/poll.js.es6 | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/plugins/poll/assets/javascripts/initializers/poll.js.es6 b/plugins/poll/assets/javascripts/initializers/poll.js.es6 index 2e7e2eaa6ba..c55cac7eca9 100644 --- a/plugins/poll/assets/javascripts/initializers/poll.js.es6 +++ b/plugins/poll/assets/javascripts/initializers/poll.js.es6 @@ -9,9 +9,12 @@ var Poll = Discourse.Model.extend({ this.updateFromJson(this.get('post.poll_details')); }.observes('post.poll_details'), - fetchNewPostDetails: function() { - this.get('post.topic.postStream').triggerChangedPost(this.get('post.id'), this.get('post.topic.updated_at')); - }.observes('post.topic.title'), + fetchNewPostDetails: Discourse.debounce(function() { + var self = this; + Discourse.debounce(function() { + self.get('post.topic.postStream').triggerChangedPost(self.get('post.id'), self.get('post.topic.updated_at')); + }, 500); + }).observes('post.topic.title'), updateFromJson: function(json) { var selectedOption = json["selected"]; @@ -24,8 +27,8 @@ var Poll = Discourse.Model.extend({ checked: (option === selectedOption) })); }); - this.set('options', options); + this.set('options', options); this.set('closed', json.closed); },