Merge pull request #1533 from velesin/remove_return_from_attach_view_with_args
removes unused return statement from ContainerView.attachViewWithArgs
This commit is contained in:
commit
d206e1416c
|
@ -15,13 +15,11 @@ Discourse.ContainerView = Ember.ContainerView.extend(Discourse.Presence, {
|
||||||
@method attachViewWithArgs
|
@method attachViewWithArgs
|
||||||
@param {Object} viewArgs The arguments to pass when creating the view
|
@param {Object} viewArgs The arguments to pass when creating the view
|
||||||
@param {Class} klass The view class we want to create
|
@param {Class} klass The view class we want to create
|
||||||
@return {Ember.View} the view we created
|
|
||||||
**/
|
**/
|
||||||
attachViewWithArgs: function(viewArgs, viewClass) {
|
attachViewWithArgs: function(viewArgs, viewClass) {
|
||||||
if (!viewClass) { viewClass = Ember.View.extend(); }
|
if (!viewClass) { viewClass = Ember.View.extend(); }
|
||||||
var view = this.createChildView(viewClass, viewArgs);
|
var view = this.createChildView(viewClass, viewArgs);
|
||||||
this.pushObject(view);
|
this.pushObject(view);
|
||||||
return view;
|
|
||||||
},
|
},
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
@ -29,7 +27,6 @@ Discourse.ContainerView = Ember.ContainerView.extend(Discourse.Presence, {
|
||||||
|
|
||||||
@method attachViewClass
|
@method attachViewClass
|
||||||
@param {Class} klass The view class we want to create
|
@param {Class} klass The view class we want to create
|
||||||
@return {Ember.View} the view we created
|
|
||||||
**/
|
**/
|
||||||
attachViewClass: function(viewClass) {
|
attachViewClass: function(viewClass) {
|
||||||
this.attachViewWithArgs(null, viewClass);
|
this.attachViewWithArgs(null, viewClass);
|
||||||
|
|
Loading…
Reference in New Issue