Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Try fix keyboard shortcut acceptance tests (#13576) 

Page was not scrolled to top so buttons were not in
viewport, so they were being hidden.
This commit is contained in:
Martin Brennan 2021-07-01 12:25:26 +10:00 committed by GitHub
parent c54d58e28f
commit d2e867ae09
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
app/assets/javascripts/discourse/tests/acceptance/keyboard-shortcuts-test.js
View File

@ -58,8 +58,6 @@ acceptance("Keyboard Shortcuts - Authenticated Users", function (needs) {
needs.hooks.beforeEach(() => { needs.hooks.beforeEach(() => {
resetNewCalled = 0; resetNewCalled = 0;
markReadCalled = 0; markReadCalled = 0;
});
needs.pretender((server, helper) => {
topicList = cloneJSON(DiscoveryFixtures["/latest.json"]); topicList = cloneJSON(DiscoveryFixtures["/latest.json"]);
// get rid of some of the topics and the more_topics_url // get rid of some of the topics and the more_topics_url
@ -67,7 +65,8 @@ acceptance("Keyboard Shortcuts - Authenticated Users", function (needs) {
// the bottom dismiss button // the bottom dismiss button
topicList.topic_list.topics.splice(20, 30); topicList.topic_list.topics.splice(20, 30);
topicList.topic_list.more_topics_url = null; topicList.topic_list.more_topics_url = null;
});
needs.pretender((server, helper) => {
server.get("/unread.json", () => { server.get("/unread.json", () => {
return helper.response(topicList); return helper.response(topicList);
}); });
@ -85,8 +84,10 @@ acceptance("Keyboard Shortcuts - Authenticated Users", function (needs) {
}); });
test("dismiss unread from top and bottom button", async function (assert) { test("dismiss unread from top and bottom button", async function (assert) {
// visit root first so topic list starts fresh // need to scroll to top so the viewport shows the top of the page
// and top dismiss button
await visit("/"); await visit("/");
document.getElementById("ember-testing-container").scrollTop = 0;
await visit("/unread"); await visit("/unread");
assert.ok( assert.ok(
exists("#dismiss-topics-top"), exists("#dismiss-topics-top"),
@ -145,8 +146,10 @@ acceptance("Keyboard Shortcuts - Authenticated Users", function (needs) {
}); });
test("dismiss new from top and bottom button", async function (assert) { test("dismiss new from top and bottom button", async function (assert) {
// visit root first so topic list starts fresh // need to scroll to top so the viewport shows the top of the page
// and top dismiss button
await visit("/"); await visit("/");
document.getElementById("ember-testing-container").scrollTop = 0;
await visit("/new"); await visit("/new");
assert.ok(exists("#dismiss-new-top"), "dismiss new top button is present"); assert.ok(exists("#dismiss-new-top"), "dismiss new top button is present");
await triggerKeyEvent(document, "keypress", "x".charCodeAt(0)); await triggerKeyEvent(document, "keypress", "x".charCodeAt(0));
@ -175,10 +178,15 @@ acceptance("Keyboard Shortcuts - Authenticated Users", function (needs) {
}); });
test("click event not fired twice when both dismiss buttons are present", async function (assert) { test("click event not fired twice when both dismiss buttons are present", async function (assert) {
// visit root first so topic list starts fresh // need to scroll to top so the viewport shows the top of the page
// and top dismiss button
await visit("/"); await visit("/");
document.getElementById("ember-testing-container").scrollTop = 0;
await visit("/new"); await visit("/new");
assert.ok(exists("#dismiss-new-top"), "dismiss new top button is present"); assert.ok(
exists("#dismiss-new-top"),
"dismiss new top button is present before double click test"
);
assert.ok( assert.ok(
exists("#dismiss-new-bottom"), exists("#dismiss-new-bottom"),
"dismiss new bottom button is present" "dismiss new bottom button is present"