From d3f07122c4b62edbcbf397704385213e172dba99 Mon Sep 17 00:00:00 2001 From: Vinoth Kannan Date: Wed, 15 Mar 2017 12:22:49 +0530 Subject: [PATCH] UX: 'Join Group' button position moved to group header --- .../discourse/templates/group-index.hbs | 4 --- .../javascripts/discourse/templates/group.hbs | 30 ++++++++++++------- app/assets/stylesheets/mobile/group.scss | 3 +- 3 files changed, 21 insertions(+), 16 deletions(-) diff --git a/app/assets/javascripts/discourse/templates/group-index.hbs b/app/assets/javascripts/discourse/templates/group-index.hbs index 86a35b11122..a58ed87a3c4 100644 --- a/app/assets/javascripts/discourse/templates/group-index.hbs +++ b/app/assets/javascripts/discourse/templates/group-index.hbs @@ -1,7 +1,3 @@ -{{group-membership-button model=model - createNewMessageViaParams='createNewMessageViaParams' - showLogin='showLogin'}} - {{#if hasMembers}} {{#load-more selector=".group-members tr" action="loadMore"}} diff --git a/app/assets/javascripts/discourse/templates/group.hbs b/app/assets/javascripts/discourse/templates/group.hbs index 571c1813d6e..95fcabb36a7 100644 --- a/app/assets/javascripts/discourse/templates/group.hbs +++ b/app/assets/javascripts/discourse/templates/group.hbs @@ -29,17 +29,25 @@ {{/if}} - {{#mobile-nav class='group-nav' desktopClass="nav nav-pills" currentPath=application.currentPath}} - {{#each getTabs as |tab|}} -
  • - {{#link-to tab.location model title=tab.message}} - {{#if tab.icon}}{{fa-icon tab.icon}}{{/if}} - {{tab.message}} - {{#if tab.count}}({{tab.count}}){{/if}} - {{/link-to}} -
  • - {{/each}} - {{/mobile-nav}} +
    +
    + {{#mobile-nav class='group-nav' desktopClass="nav nav-pills" currentPath=application.currentPath}} + {{#each getTabs as |tab|}} +
  • + {{#link-to tab.location model title=tab.message}} + {{#if tab.icon}}{{fa-icon tab.icon}}{{/if}} + {{tab.message}} + {{#if tab.count}}({{tab.count}}){{/if}} + {{/link-to}} +
  • + {{/each}} + {{/mobile-nav}} + + {{group-membership-button model=model + createNewMessageViaParams='createNewMessageViaParams' + showLogin='showLogin'}} +
    +
    {{outlet}} diff --git a/app/assets/stylesheets/mobile/group.scss b/app/assets/stylesheets/mobile/group.scss index cfbb849340b..ded66e71845 100644 --- a/app/assets/stylesheets/mobile/group.scss +++ b/app/assets/stylesheets/mobile/group.scss @@ -20,6 +20,7 @@ .group-nav.mobile-nav { margin-bottom: 15px; + float: left; } .group-activity { @@ -29,7 +30,7 @@ .group-activity-nav.mobile-nav { position: absolute; right: 0px; - top: -50px; + top: -55px; } .group-activity-outlet {