Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

UX: Change AdminPageSubheader to H2 (#29149) 

Since the AdminPageHeader is H1, it is more semantically
correct to progress to H2 after it rather than skipping
a level to H3

Also amend style of H2 to make it the same size as H3
This commit is contained in:
Martin Brennan 2024-10-10 17:18:26 +10:00 committed by GitHub
parent 663ce73e26
commit d56bb72819
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/admin/addon/components/admin-page-subheader.gjs
View File

@ -38,7 +38,7 @@ export default class AdminPageSubheader extends Component {
<template> <template>
<div class="admin-page-subheader"> <div class="admin-page-subheader">
<div class="admin-page-subheader__title-row"> <div class="admin-page-subheader__title-row">
<h3 class="admin-page-subheader__title">{{this.title}}</h3> <h2 class="admin-page-subheader__title">{{this.title}}</h2>
{{#if (has-block "actions")}} {{#if (has-block "actions")}}
<div class="admin-page-subheader__actions"> <div class="admin-page-subheader__actions">
{{#if this.site.mobileView}} {{#if this.site.mobileView}}

6
app/assets/stylesheets/common/admin/admin_page_header.scss
View File

@ -7,10 +7,14 @@
margin-bottom: var(--space-2); margin-bottom: var(--space-2);
h1, h1,
h3 { h2 {
margin: 0; margin: 0;
} }
h2 {
font-size: var(--font-up-2);
}
.admin-page-header__actions { .admin-page-header__actions {
display: flex; display: flex;
align-items: center; align-items: center;