From d888a8b69230313e302c04094b965f2ccbc95110 Mon Sep 17 00:00:00 2001 From: Bianca Nenciu Date: Mon, 26 Jun 2023 18:39:29 +0300 Subject: [PATCH] FEATURE: Show first notification tip to all users (#22258) It used to show only to users with trust level 0 or 1 and users who signed up in the past week. --- app/models/user.rb | 14 +------------- spec/models/user_spec.rb | 16 ---------------- 2 files changed, 1 insertion(+), 29 deletions(-) diff --git a/app/models/user.rb b/app/models/user.rb index 1810f3f024d..8e0e0dbc4eb 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -808,20 +808,8 @@ class User < ActiveRecord::Base MessageBus.publish("/reviewable_counts/#{self.id}", data, user_ids: [self.id]) end - TRACK_FIRST_NOTIFICATION_READ_DURATION = 1.week.to_i - def read_first_notification? - if ( - trust_level > TrustLevel[1] || - ( - first_seen_at.present? && - first_seen_at < TRACK_FIRST_NOTIFICATION_READ_DURATION.seconds.ago - ) || user_option.skip_new_user_tips - ) - return true - end - - self.seen_notification_id == 0 ? false : true + self.seen_notification_id != 0 || user_option.skip_new_user_tips end def publish_notifications_state diff --git a/spec/models/user_spec.rb b/spec/models/user_spec.rb index 1c5ecc381d9..de58c411914 100644 --- a/spec/models/user_spec.rb +++ b/spec/models/user_spec.rb @@ -2208,22 +2208,6 @@ RSpec.describe User do end end - describe "when user is trust level 2" do - it "should return the right value" do - user.update!(trust_level: TrustLevel[2]) - - expect(user.read_first_notification?).to eq(true) - end - end - - describe "when user is an old user" do - it "should return the right value" do - user.update!(first_seen_at: 1.year.ago) - - expect(user.read_first_notification?).to eq(true) - end - end - describe "when user skipped new user tips" do it "should return the right value" do user.user_option.update!(skip_new_user_tips: true)