Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: Scale down swipe in detection to 20px from edge of the screen 

...and slightly increase velocity required for menu actions
This commit is contained in:
Jeff Wong 2019-02-11 21:22:50 -08:00
parent c3cbff55be
commit d997b01a24
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/discourse/components/site-header.js.es6
View File

@ -15,7 +15,7 @@ function addFlagProperty(prop) {
const PANEL_BODY_MARGIN = 30; const PANEL_BODY_MARGIN = 30;
//android supports pulling in from the screen edges //android supports pulling in from the screen edges
const SCREEN_EDGE_MARGIN = 30; const SCREEN_EDGE_MARGIN = 20;
const SCREEN_OFFSET = 300; const SCREEN_OFFSET = 300;
const SiteHeaderComponent = MountWidget.extend(Docking, PanEvents, { const SiteHeaderComponent = MountWidget.extend(Docking, PanEvents, {

5
app/assets/javascripts/discourse/mixins/pan-events.js.es6
View File

@ -4,7 +4,8 @@
**/ **/
export const SWIPE_VELOCITY = 40; export const SWIPE_VELOCITY = 40;
export const SWIPE_DISTANCE_THRESHOLD = 50; export const SWIPE_DISTANCE_THRESHOLD = 50;
export const SWIPE_VELOCITY_THRESHOLD = 0.1; export const SWIPE_VELOCITY_THRESHOLD = 0.12;
export const MINIMUM_SWIPE_DISTANCE = 5;
export default Ember.Mixin.create({ export default Ember.Mixin.create({
//velocity is pixels per ms //velocity is pixels per ms
@ -120,7 +121,7 @@ export default Ember.Mixin.create({
} }
const previousState = this.get("_panState"); const previousState = this.get("_panState");
const newState = this._calculateNewPanState(previousState, e); const newState = this._calculateNewPanState(previousState, e);
if (previousState.start && newState.distance < 5) { if (previousState.start && newState.distance < MINIMUM_SWIPE_DISTANCE) {
return; return;
} }
this.set("_panState", newState); this.set("_panState", newState);