Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Update period-title.js (#20422) 

(A petty but important typography fix)

Use en dash (–) instead of hyphen (-) for ranges (including dates)
For example — 1–2, May–June, 1:00pm–2:00pm

A space in before and after the dash is usually not present in writing but for user interfaces can be stylistic choice. (The space is left unchanged here.)

References
- https://learn.microsoft.com/en-us/style-guide/punctuation/dashes-hyphens/enes
- https://www.thepunctuationguide.com/en-dash.html
This commit is contained in:
carsick 2023-02-22 23:00:41 -08:00 committed by GitHub
parent 0a619d8c88
commit da43b60510
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/assets/javascripts/discourse/app/helpers/period-title.js
View File

@ -28,7 +28,7 @@ export default htmlHelper((period, options) => {
.clone()
.subtract(1, "year")
.format(I18n.t("dates.long_with_year_no_time")) +
" - " +
" – " +
finish.format(I18n.t("dates.long_with_year_no_time"));
break;
case "quarterly":
@ -37,7 +37,7 @@ export default htmlHelper((period, options) => {
.clone()
.subtract(3, "month")
.format(I18n.t("dates.long_no_year_no_time")) +
" - " +
" – " +
finish.format(I18n.t("dates.long_no_year_no_time"));
break;
case "weekly":
@ -50,7 +50,7 @@ export default htmlHelper((period, options) => {
dateString =
start.format(I18n.t("dates.long_no_year_no_time")) +
" - " +
" – " +
finish.format(I18n.t("dates.long_no_year_no_time"));
break;
case "monthly":
@ -59,7 +59,7 @@ export default htmlHelper((period, options) => {
.clone()
.subtract(1, "month")
.format(I18n.t("dates.long_no_year_no_time")) +
" - " +
" – " +
finish.format(I18n.t("dates.long_no_year_no_time"));
break;
case "daily":