From db9840b6722fa5aadd383f4daebc17b20f7ff25a Mon Sep 17 00:00:00 2001 From: Rimian Perkins Date: Fri, 24 Feb 2017 10:19:34 +1100 Subject: [PATCH] fix malformed qunit url this removes the space between the query string and the URL ``` $MODULE='Acceptance: Search' rake qunit:test\[20000\] .... Running: {"module":"Acceptance: Search"} ... http://localhost:60099/qunit?module=Acceptance%3A%20Search 20000 ``` The timeout value seems to work fine. --- lib/tasks/qunit.rake | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/tasks/qunit.rake b/lib/tasks/qunit.rake index b4e9e228875..9baf48a1af8 100644 --- a/lib/tasks/qunit.rake +++ b/lib/tasks/qunit.rake @@ -35,7 +35,7 @@ task "qunit:test", [:timeout] => :environment do |_, args| begin success = true test_path = "#{Rails.root}/vendor/assets/javascripts" - cmd = "phantomjs #{test_path}/run-qunit.js http://localhost:#{port}/qunit #{args[:timeout]}" + cmd = "phantomjs #{test_path}/run-qunit.js http://localhost:#{port}/qunit" options = {} @@ -47,6 +47,10 @@ task "qunit:test", [:timeout] => :environment do |_, args| cmd += "?#{options.to_query.gsub('+', '%20')}" end + if args[:timeout].present? + cmd += " #{args[:timeout]}" + end + # wait for server to respond, will exception out on failure tries = 0 begin