From dc02586d99bceac2e78a7690d9265e93310645d5 Mon Sep 17 00:00:00 2001 From: Martin Brennan Date: Fri, 13 Mar 2020 13:33:57 +1000 Subject: [PATCH] Fix error on create bookmark for topic --- app/controllers/topics_controller.rb | 2 +- spec/requests/topics_controller_spec.rb | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/app/controllers/topics_controller.rb b/app/controllers/topics_controller.rb index 61b6d4bd688..ee7ba1af180 100644 --- a/app/controllers/topics_controller.rb +++ b/app/controllers/topics_controller.rb @@ -551,7 +551,7 @@ class TopicsController < ApplicationController bookmark_manager = BookmarkManager.new(current_user) bookmark_manager.create(post_id: first_post.id) - if bookmark_manager.errors + if bookmark_manager.errors.any? return render_json_error(bookmark_manager, status: 400) end else diff --git a/spec/requests/topics_controller_spec.rb b/spec/requests/topics_controller_spec.rb index 42f002f4816..845a7e1930a 100644 --- a/spec/requests/topics_controller_spec.rb +++ b/spec/requests/topics_controller_spec.rb @@ -2376,6 +2376,7 @@ RSpec.describe TopicsController do post = create_post post2 = create_post(topic_id: post.topic_id) put "/t/#{post.topic_id}/bookmark.json" + expect(response.status).to eq(200) bookmarks_for_topic = Bookmark.where(topic: post.topic, user: user) expect(bookmarks_for_topic.count).to eq(1)