DEV: refactors textarea-selection helper to prevent leaking (#7709)

.eslintrc

@@ -59,8 +59,6 @@
     "selectKitSelectRowByIndex": true,
     "selectKitSelectRowByName": true,
     "selectKitSelectRowByValue": true,
-    "setTextareaSelection": true,
-    "getTextareaSelection": true,
     "sinon": true,
     "test": true,
     "triggerEvent": true,

test/javascripts/components/d-editor-test.js.es6

@@ -1,6 +1,10 @@
 import componentTest from "helpers/component-test";
 import { withPluginApi } from "discourse/lib/plugin-api";
 import formatTextWithSelection from "helpers/d-editor-helper";
+import {
+  setTextareaSelection,
+  getTextareaSelection
+} from "helpers/textarea-selection-helper";
 
 moduleForComponent("d-editor", { integration: true });
 

test/javascripts/helpers/textarea-selection-helper.js.es6

@@ -0,0 +1,10 @@
+export function setTextareaSelection(textarea, selectionStart, selectionEnd) {
+  textarea.selectionStart = selectionStart;
+  textarea.selectionEnd = selectionEnd;
+}
+
+export function getTextareaSelection(textarea) {
+  const start = textarea.selectionStart;
+  const end = textarea.selectionEnd;
+  return [start, end - start];
+}

test/javascripts/helpers/textarea-selection.js

@@ -1,15 +0,0 @@
-Ember.Test.registerHelper("setTextareaSelection", function(
-  app,
-  textarea,
-  selectionStart,
-  selectionEnd
-) {
-  textarea.selectionStart = selectionStart;
-  textarea.selectionEnd = selectionEnd;
-});
-
-Ember.Test.registerHelper("getTextareaSelection", function(app, textarea) {
-  var start = textarea.selectionStart;
-  var end = textarea.selectionEnd;
-  return [start, end - start];
-});

test/javascripts/test_helper.js

@@ -30,7 +30,6 @@
 //= require sinon/pkg/sinon
 
 //= require helpers/assertions
-//= require helpers/textarea-selection
 //= require helpers/select-kit-helper
 
 //= require helpers/qunit-helpers