DEV: Specify target browsers when running Ember CLI tests from the docker rake task (#14720)

This commit is contained in:
Roman Rizzi 2021-10-26 11:10:22 -03:00 committed by GitHub
parent be38615afd
commit dfb7924105
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions

View File

@ -19,6 +19,7 @@
# => JS_TIMEOUT set timeout for qunit tests in ms
# => WARMUP_TMP_FOLDER runs a single spec to warmup the tmp folder and obtain accurate results when profiling specs.
# => EMBER_CLI set to 1 to run JS tests using the Ember CLI
# => EMBER_CLI_BROWSERS comma separated list of browsers to test against. Options are Chrome, Firefox, and Headless Firefox.
#
# Other useful environment variables (not specific to this rake task)
# => COMMIT_HASH used by the discourse_test docker image to load a specific commit of discourse
@ -225,8 +226,9 @@ task 'docker:test' do
if ENV["EMBER_CLI"]
Dir.chdir("#{Rails.root}/app/assets/javascripts/discourse") do # rubocop:disable Discourse/NoChdir
browsers = ENV["EMBER_CLI_BROWSERS"] || 'Chrome'
@good &&= run_or_fail("yarn install")
@good &&= run_or_fail("yarn ember test")
@good &&= run_or_fail("yarn ember test --launch #{browsers}")
end
end
end