FIX: deprecation warning - initialization autoloaded the constant (#12400)
Get rid of deprecation related to Zeitwerk autoloader. Original PR was reverted because of multisite bug #12381 - thank you @davidtaylorhq for fixing it. I added the last commit to fix that multisite problem.
This commit is contained in:
Krzysztof Kotlarek
GitHub
parent
ddf8e9b6b6
commit
e10a74694a
|
|
@ -55,6 +55,8 @@ require 'pry-rails' if Rails.env.development?
|
||||||
|
|
||||||
require 'discourse_fonts'
|
require 'discourse_fonts'
|
||||||
|
|
||||||
|
require_relative '../lib/zeitwerk_config.rb'
|
||||||
|
|
||||||
if defined?(Bundler)
|
if defined?(Bundler)
|
||||||
bundler_groups = [:default]
|
bundler_groups = [:default]
|
||||||
|
|
||||||
|
|
@ -116,6 +118,7 @@ module Discourse
|
||||||
config.autoload_paths += Dir["#{config.root}/lib/validators/"]
|
config.autoload_paths += Dir["#{config.root}/lib/validators/"]
|
||||||
|
|
||||||
Rails.autoloaders.main.ignore(Dir["#{config.root}/app/models/reports"])
|
Rails.autoloaders.main.ignore(Dir["#{config.root}/app/models/reports"])
|
||||||
|
Rails.autoloaders.main.ignore(Dir["#{config.root}/lib/freedom_patches"])
|
||||||
|
|
||||||
# Only load the plugins named here, in the order given (default is alphabetical).
|
# Only load the plugins named here, in the order given (default is alphabetical).
|
||||||
# :all can be used as a placeholder for all plugins not explicitly named.
|
# :all can be used as a placeholder for all plugins not explicitly named.
|
||||||
|
|
|
||||||
|
|
@ -1,5 +1,13 @@
|
||||||
# frozen_string_literal: true
|
# frozen_string_literal: true
|
||||||
|
|
||||||
Dir["#{Rails.root}/lib/freedom_patches/*.rb"].each do |f|
|
# Multisite freedom patch defines RailsMultisite::DiscoursePatches.config which is used by 200-first_middlewares.rb
|
||||||
require(f)
|
# Therefore it can not be postponed with .to_prepare
|
||||||
|
RUN_WITHOUT_PREPARE = ["#{Rails.root}/lib/freedom_patches/rails_multisite.rb"]
|
||||||
|
RUN_WITHOUT_PREPARE.each { |path| require(path) }
|
||||||
|
|
||||||
|
Rails.application.reloader.to_prepare do
|
||||||
|
Dir["#{Rails.root}/lib/freedom_patches/*.rb"].each do |f|
|
||||||
|
next if RUN_WITHOUT_PREPARE.any? { |path| path == f }
|
||||||
|
require(f)
|
||||||
|
end
|
||||||
end
|
end
|
||||||
|
|
|
||||||
|
|
@ -16,24 +16,26 @@ if GlobalSetting.skip_redis?
|
||||||
return
|
return
|
||||||
end
|
end
|
||||||
|
|
||||||
reload_settings = lambda {
|
Rails.application.reloader.to_prepare do
|
||||||
RailsMultisite::ConnectionManagement.safe_each_connection do
|
reload_settings = lambda {
|
||||||
begin
|
RailsMultisite::ConnectionManagement.safe_each_connection do
|
||||||
SiteSetting.refresh!
|
begin
|
||||||
|
SiteSetting.refresh!
|
||||||
|
|
||||||
unless String === SiteSetting.push_api_secret_key && SiteSetting.push_api_secret_key.length == 32
|
unless String === SiteSetting.push_api_secret_key && SiteSetting.push_api_secret_key.length == 32
|
||||||
SiteSetting.push_api_secret_key = SecureRandom.hex
|
SiteSetting.push_api_secret_key = SecureRandom.hex
|
||||||
|
end
|
||||||
|
rescue ActiveRecord::StatementInvalid
|
||||||
|
# This will happen when migrating a new database
|
||||||
end
|
end
|
||||||
rescue ActiveRecord::StatementInvalid
|
end
|
||||||
# This will happen when migrating a new database
|
}
|
||||||
|
|
||||||
|
reload_settings.call
|
||||||
|
|
||||||
|
if !Rails.configuration.cache_classes
|
||||||
|
ActiveSupport::Reloader.to_prepare do
|
||||||
|
reload_settings.call
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
}
|
|
||||||
|
|
||||||
reload_settings.call
|
|
||||||
|
|
||||||
if !Rails.configuration.cache_classes
|
|
||||||
ActiveSupport::Reloader.to_prepare do
|
|
||||||
reload_settings.call
|
|
||||||
end
|
|
||||||
end
|
end
|
||||||
|
|
|
||||||
|
|
@ -5,15 +5,17 @@
|
||||||
require 'i18n/backend/discourse_i18n'
|
require 'i18n/backend/discourse_i18n'
|
||||||
require 'i18n/backend/fallback_locale_list'
|
require 'i18n/backend/fallback_locale_list'
|
||||||
|
|
||||||
I18n.backend = I18n::Backend::DiscourseI18n.new
|
Rails.application.reloader.to_prepare do
|
||||||
I18n.fallbacks = I18n::Backend::FallbackLocaleList.new
|
I18n.backend = I18n::Backend::DiscourseI18n.new
|
||||||
I18n.config.missing_interpolation_argument_handler = proc { throw(:exception) }
|
I18n.fallbacks = I18n::Backend::FallbackLocaleList.new
|
||||||
I18n.reload!
|
I18n.config.missing_interpolation_argument_handler = proc { throw(:exception) }
|
||||||
I18n.init_accelerator!(overrides_enabled: ENV['DISABLE_TRANSLATION_OVERRIDES'] != '1')
|
I18n.reload!
|
||||||
|
I18n.init_accelerator!(overrides_enabled: ENV['DISABLE_TRANSLATION_OVERRIDES'] != '1')
|
||||||
|
|
||||||
unless Rails.env.test?
|
unless Rails.env.test?
|
||||||
MessageBus.subscribe("/i18n-flush") do
|
MessageBus.subscribe("/i18n-flush") do
|
||||||
I18n.reload!
|
I18n.reload!
|
||||||
ExtraLocalesController.clear_cache!
|
ExtraLocalesController.clear_cache!
|
||||||
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
|
||||||
|
|
@ -1,148 +1,152 @@
|
||||||
# frozen_string_literal: true
|
# frozen_string_literal: true
|
||||||
|
|
||||||
if GlobalSetting.skip_redis?
|
if GlobalSetting.skip_redis?
|
||||||
if Rails.logger.respond_to? :chained
|
Rails.application.reloader.to_prepare do
|
||||||
Rails.logger = Rails.logger.chained.first
|
if Rails.logger.respond_to? :chained
|
||||||
|
Rails.logger = Rails.logger.chained.first
|
||||||
|
end
|
||||||
end
|
end
|
||||||
return
|
return
|
||||||
end
|
end
|
||||||
|
|
||||||
if Rails.env.development? && RUBY_VERSION.match?(/^2\.5\.[23]/)
|
Rails.application.reloader.to_prepare do
|
||||||
STDERR.puts "WARNING: Discourse development environment runs slower on Ruby 2.5.3 or below"
|
if Rails.env.development? && RUBY_VERSION.match?(/^2\.5\.[23]/)
|
||||||
STDERR.puts "We recommend you upgrade to Ruby 2.6.1 for the optimal development performance"
|
STDERR.puts "WARNING: Discourse development environment runs slower on Ruby 2.5.3 or below"
|
||||||
|
STDERR.puts "We recommend you upgrade to Ruby 2.6.1 for the optimal development performance"
|
||||||
|
|
||||||
# we have to used to older and slower version of the logger cause the new one exposes a Ruby bug in
|
# we have to used to older and slower version of the logger cause the new one exposes a Ruby bug in
|
||||||
# the Queue class which causes segmentation faults
|
# the Queue class which causes segmentation faults
|
||||||
Logster::Scheduler.disable
|
Logster::Scheduler.disable
|
||||||
end
|
|
||||||
|
|
||||||
if Rails.env.development? && !Sidekiq.server? && ENV["RAILS_LOGS_STDOUT"] == "1"
|
|
||||||
console = ActiveSupport::Logger.new(STDOUT)
|
|
||||||
original_logger = Rails.logger.chained.first
|
|
||||||
console.formatter = original_logger.formatter
|
|
||||||
console.level = original_logger.level
|
|
||||||
|
|
||||||
unless ActiveSupport::Logger.logger_outputs_to?(original_logger, STDOUT)
|
|
||||||
original_logger.extend(ActiveSupport::Logger.broadcast(console))
|
|
||||||
end
|
end
|
||||||
end
|
|
||||||
|
|
||||||
if Rails.env.production?
|
if Rails.env.development? && !Sidekiq.server? && ENV["RAILS_LOGS_STDOUT"] == "1"
|
||||||
Logster.store.ignore = [
|
console = ActiveSupport::Logger.new(STDOUT)
|
||||||
# honestly, Rails should not be logging this, its real noisy
|
original_logger = Rails.logger.chained.first
|
||||||
/^ActionController::RoutingError \(No route matches/,
|
console.formatter = original_logger.formatter
|
||||||
|
console.level = original_logger.level
|
||||||
|
|
||||||
/^PG::Error: ERROR:\s+duplicate key/,
|
unless ActiveSupport::Logger.logger_outputs_to?(original_logger, STDOUT)
|
||||||
|
original_logger.extend(ActiveSupport::Logger.broadcast(console))
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
/^ActionController::UnknownFormat/,
|
if Rails.env.production?
|
||||||
/^ActionController::UnknownHttpMethod/,
|
Logster.store.ignore = [
|
||||||
/^AbstractController::ActionNotFound/,
|
# honestly, Rails should not be logging this, its real noisy
|
||||||
# ignore any empty JS errors that contain blanks or zeros for line and column fields
|
/^ActionController::RoutingError \(No route matches/,
|
||||||
#
|
|
||||||
# Line:
|
|
||||||
# Column:
|
|
||||||
#
|
|
||||||
/(?m).*?Line: (?:\D|0).*?Column: (?:\D|0)/,
|
|
||||||
|
|
||||||
# suppress empty JS errors (covers MSIE 9, etc)
|
/^PG::Error: ERROR:\s+duplicate key/,
|
||||||
/^(Syntax|Script) error.*Line: (0|1)\b/m,
|
|
||||||
|
|
||||||
# CSRF errors are not providing enough data
|
/^ActionController::UnknownFormat/,
|
||||||
# suppress unconditionally for now
|
/^ActionController::UnknownHttpMethod/,
|
||||||
/^Can't verify CSRF token authenticity.$/,
|
/^AbstractController::ActionNotFound/,
|
||||||
|
# ignore any empty JS errors that contain blanks or zeros for line and column fields
|
||||||
|
#
|
||||||
|
# Line:
|
||||||
|
# Column:
|
||||||
|
#
|
||||||
|
/(?m).*?Line: (?:\D|0).*?Column: (?:\D|0)/,
|
||||||
|
|
||||||
# Yandex bot triggers this JS error a lot
|
# suppress empty JS errors (covers MSIE 9, etc)
|
||||||
/^Uncaught ReferenceError: I18n is not defined/,
|
/^(Syntax|Script) error.*Line: (0|1)\b/m,
|
||||||
|
|
||||||
# related to browser plugins somehow, we don't care
|
# CSRF errors are not providing enough data
|
||||||
/Error calling method on NPObject/,
|
# suppress unconditionally for now
|
||||||
|
/^Can't verify CSRF token authenticity.$/,
|
||||||
|
|
||||||
# 404s can be dealt with elsewhere
|
# Yandex bot triggers this JS error a lot
|
||||||
/^ActiveRecord::RecordNotFound/,
|
/^Uncaught ReferenceError: I18n is not defined/,
|
||||||
|
|
||||||
# bad asset requested, no need to log
|
# related to browser plugins somehow, we don't care
|
||||||
/^ActionController::BadRequest/,
|
/Error calling method on NPObject/,
|
||||||
|
|
||||||
# we can't do anything about invalid parameters
|
# 404s can be dealt with elsewhere
|
||||||
/Rack::QueryParser::InvalidParameterError/,
|
/^ActiveRecord::RecordNotFound/,
|
||||||
|
|
||||||
# we handle this cleanly in the message bus middleware
|
# bad asset requested, no need to log
|
||||||
# no point logging to logster
|
/^ActionController::BadRequest/,
|
||||||
/RateLimiter::LimitExceeded.*/m,
|
|
||||||
|
|
||||||
# see https://github.com/rails/rails/issues/34599
|
# we can't do anything about invalid parameters
|
||||||
# Poll defines an enum with the value `open` ActiveRecord then attempts
|
/Rack::QueryParser::InvalidParameterError/,
|
||||||
# AR then warns cause #open is being redefined, it is already defined
|
|
||||||
# privately in Kernel per: http://ruby-doc.org/core-2.5.3/Kernel.html#method-i-open
|
# we handle this cleanly in the message bus middleware
|
||||||
# Once the rails issue is fixed we can stop this error suppression and stop defining
|
# no point logging to logster
|
||||||
# scopes for the enums
|
/RateLimiter::LimitExceeded.*/m,
|
||||||
/^Creating scope :open\. Overwriting existing method Poll\.open\./,
|
|
||||||
|
# see https://github.com/rails/rails/issues/34599
|
||||||
|
# Poll defines an enum with the value `open` ActiveRecord then attempts
|
||||||
|
# AR then warns cause #open is being redefined, it is already defined
|
||||||
|
# privately in Kernel per: http://ruby-doc.org/core-2.5.3/Kernel.html#method-i-open
|
||||||
|
# Once the rails issue is fixed we can stop this error suppression and stop defining
|
||||||
|
# scopes for the enums
|
||||||
|
/^Creating scope :open\. Overwriting existing method Poll\.open\./,
|
||||||
|
]
|
||||||
|
Logster.config.env_expandable_keys.push(:hostname, :problem_db)
|
||||||
|
end
|
||||||
|
|
||||||
|
Logster.store.max_backlog = GlobalSetting.max_logster_logs
|
||||||
|
|
||||||
|
# TODO logster should be able to do this automatically
|
||||||
|
Logster.config.subdirectory = "#{GlobalSetting.relative_url_root}/logs"
|
||||||
|
|
||||||
|
Logster.config.application_version = Discourse.git_version
|
||||||
|
Logster.config.enable_custom_patterns_via_ui = true
|
||||||
|
Logster.config.enable_js_error_reporting = GlobalSetting.enable_js_error_reporting
|
||||||
|
|
||||||
|
store = Logster.store
|
||||||
|
redis = Logster.store.redis
|
||||||
|
store.redis_prefix = Proc.new { redis.namespace }
|
||||||
|
store.redis_raw_connection = redis.without_namespace
|
||||||
|
severities = [Logger::WARN, Logger::ERROR, Logger::FATAL, Logger::UNKNOWN]
|
||||||
|
|
||||||
|
RailsMultisite::ConnectionManagement.each_connection do
|
||||||
|
error_rate_per_minute = SiteSetting.alert_admins_if_errors_per_minute rescue 0
|
||||||
|
|
||||||
|
if (error_rate_per_minute || 0) > 0
|
||||||
|
store.register_rate_limit_per_minute(severities, error_rate_per_minute) do |rate|
|
||||||
|
MessageBus.publish("/logs_error_rate_exceeded",
|
||||||
|
{
|
||||||
|
rate: rate,
|
||||||
|
duration: 'minute',
|
||||||
|
publish_at: Time.current.to_i
|
||||||
|
},
|
||||||
|
group_ids: [Group::AUTO_GROUPS[:admins]]
|
||||||
|
)
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
|
error_rate_per_hour = SiteSetting.alert_admins_if_errors_per_hour rescue 0
|
||||||
|
|
||||||
|
if (error_rate_per_hour || 0) > 0
|
||||||
|
store.register_rate_limit_per_hour(severities, error_rate_per_hour) do |rate|
|
||||||
|
MessageBus.publish("/logs_error_rate_exceeded",
|
||||||
|
{
|
||||||
|
rate: rate,
|
||||||
|
duration: 'hour',
|
||||||
|
publish_at: Time.current.to_i,
|
||||||
|
},
|
||||||
|
group_ids: [Group::AUTO_GROUPS[:admins]]
|
||||||
|
)
|
||||||
|
end
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
|
if Rails.configuration.multisite
|
||||||
|
if Rails.logger.respond_to? :chained
|
||||||
|
chained = Rails.logger.chained
|
||||||
|
chained && chained.first.formatter = RailsMultisite::Formatter.new
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
|
Logster.config.project_directories = [
|
||||||
|
{ path: Rails.root.to_s, url: "https://github.com/discourse/discourse", main_app: true }
|
||||||
]
|
]
|
||||||
Logster.config.env_expandable_keys.push(:hostname, :problem_db)
|
Discourse.plugins.each do |plugin|
|
||||||
end
|
next if !plugin.metadata.url
|
||||||
|
|
||||||
Logster.store.max_backlog = GlobalSetting.max_logster_logs
|
Logster.config.project_directories << {
|
||||||
|
path: "#{Rails.root.to_s}/plugins/#{plugin.directory_name}",
|
||||||
# TODO logster should be able to do this automatically
|
url: plugin.metadata.url
|
||||||
Logster.config.subdirectory = "#{GlobalSetting.relative_url_root}/logs"
|
}
|
||||||
|
|
||||||
Logster.config.application_version = Discourse.git_version
|
|
||||||
Logster.config.enable_custom_patterns_via_ui = true
|
|
||||||
Logster.config.enable_js_error_reporting = GlobalSetting.enable_js_error_reporting
|
|
||||||
|
|
||||||
store = Logster.store
|
|
||||||
redis = Logster.store.redis
|
|
||||||
store.redis_prefix = Proc.new { redis.namespace }
|
|
||||||
store.redis_raw_connection = redis.without_namespace
|
|
||||||
severities = [Logger::WARN, Logger::ERROR, Logger::FATAL, Logger::UNKNOWN]
|
|
||||||
|
|
||||||
RailsMultisite::ConnectionManagement.each_connection do
|
|
||||||
error_rate_per_minute = SiteSetting.alert_admins_if_errors_per_minute rescue 0
|
|
||||||
|
|
||||||
if (error_rate_per_minute || 0) > 0
|
|
||||||
store.register_rate_limit_per_minute(severities, error_rate_per_minute) do |rate|
|
|
||||||
MessageBus.publish("/logs_error_rate_exceeded",
|
|
||||||
{
|
|
||||||
rate: rate,
|
|
||||||
duration: 'minute',
|
|
||||||
publish_at: Time.current.to_i
|
|
||||||
},
|
|
||||||
group_ids: [Group::AUTO_GROUPS[:admins]]
|
|
||||||
)
|
|
||||||
end
|
|
||||||
end
|
|
||||||
|
|
||||||
error_rate_per_hour = SiteSetting.alert_admins_if_errors_per_hour rescue 0
|
|
||||||
|
|
||||||
if (error_rate_per_hour || 0) > 0
|
|
||||||
store.register_rate_limit_per_hour(severities, error_rate_per_hour) do |rate|
|
|
||||||
MessageBus.publish("/logs_error_rate_exceeded",
|
|
||||||
{
|
|
||||||
rate: rate,
|
|
||||||
duration: 'hour',
|
|
||||||
publish_at: Time.current.to_i,
|
|
||||||
},
|
|
||||||
group_ids: [Group::AUTO_GROUPS[:admins]]
|
|
||||||
)
|
|
||||||
end
|
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
if Rails.configuration.multisite
|
|
||||||
if Rails.logger.respond_to? :chained
|
|
||||||
chained = Rails.logger.chained
|
|
||||||
chained && chained.first.formatter = RailsMultisite::Formatter.new
|
|
||||||
end
|
|
||||||
end
|
|
||||||
|
|
||||||
Logster.config.project_directories = [
|
|
||||||
{ path: Rails.root.to_s, url: "https://github.com/discourse/discourse", main_app: true }
|
|
||||||
]
|
|
||||||
Discourse.plugins.each do |plugin|
|
|
||||||
next if !plugin.metadata.url
|
|
||||||
|
|
||||||
Logster.config.project_directories << {
|
|
||||||
path: "#{Rails.root.to_s}/plugins/#{plugin.directory_name}",
|
|
||||||
url: plugin.metadata.url
|
|
||||||
}
|
|
||||||
end
|
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue