From e1b99d3cad41ded64723fa58ca8bd8652816bc0f Mon Sep 17 00:00:00 2001 From: Robin Ward Date: Thu, 20 May 2021 14:00:25 -0400 Subject: [PATCH] FIX: Review Queue Query parameters were not refreshing in Ember CLI builds (#13101) The problem was we were setting the properties then immediately calling `refreshRoute` which was being executed before the properties were settled via the runloop. --- .../discourse/app/controllers/review-index.js | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/app/assets/javascripts/discourse/app/controllers/review-index.js b/app/assets/javascripts/discourse/app/controllers/review-index.js index 2c70242dcd5..4c194415946 100644 --- a/app/assets/javascripts/discourse/app/controllers/review-index.js +++ b/app/assets/javascripts/discourse/app/controllers/review-index.js @@ -2,6 +2,7 @@ import Controller from "@ember/controller"; import I18n from "I18n"; import discourseComputed from "discourse-common/utils/decorators"; import { isPresent } from "@ember/utils"; +import { next } from "@ember/runloop"; export default Controller.extend({ queryParams: [ @@ -93,6 +94,10 @@ export default Controller.extend({ this.setProperties(range); }, + refreshModel() { + next(() => this.send("refreshRoute")); + }, + actions: { remove(ids) { if (!ids) { @@ -104,7 +109,7 @@ export default Controller.extend({ }); if (newList.length === 0) { - this.send("refreshRoute"); + this.refreshModel(); } else { this.set("reviewables", newList); } @@ -112,7 +117,7 @@ export default Controller.extend({ resetTopic() { this.set("topic_id", null); - this.send("refreshRoute"); + this.refreshModel(); }, refresh() { @@ -165,7 +170,7 @@ export default Controller.extend({ additional_filters: JSON.stringify(this.additionalFilters), }); - this.send("refreshRoute"); + this.refreshModel(); }, loadMore() {