A11Y: Activate user menu tab on keydown too (#23593)

app/assets/javascripts/discourse/app/components/user-menu/menu-tab.hbs

@@ -9,6 +9,7 @@
   data-tab-number={{@tab.position}}
   href={{@tab.linkWhenActive}}
   {{on "click" @onTabClick}}
+  {{on "keydown" @onTabClick}}
 >
   {{d-icon @tab.icon}}
   {{#if @tab.count}}

app/assets/javascripts/discourse/app/components/user-menu/menu.js

@@ -273,6 +273,10 @@ export default class UserMenu extends Component {
       return;
     }
 
+    if (event.type === "keydown" && event.keyCode !== 13) {
+      return;
+    }
+
     event.preventDefault();
 
     this.currentTabId = tab.id;

app/assets/javascripts/discourse/tests/acceptance/user-menu-test.js

@@ -1,4 +1,4 @@
-import { click, currentURL, visit } from "@ember/test-helpers";
+import { click, currentURL, triggerKeyEvent, visit } from "@ember/test-helpers";
 import {
   acceptance,
   exists,
@@ -819,6 +819,22 @@ acceptance("User menu", function (needs) {
       window.removeEventListener("click", interceptor);
     }
   });
+
+  test("tabs without hrefs can be visited with the keyboard", async function (assert) {
+    await visit("/");
+    await click(".d-header-icons .current-user");
+
+    await triggerKeyEvent(
+      "#user-menu-button-other-notifications",
+      "keydown",
+      "Enter"
+    );
+
+    assert.ok(
+      exists("#quick-access-other-notifications"),
+      "the other notifications panel can display using keyboard navigation"
+    );
+  });
 });
 
 acceptance("User menu - Dismiss button", function (needs) {