From e25a6e085e6955a9f5d135c080fd202e180167dd Mon Sep 17 00:00:00 2001
From: Kyle Zhao <kzhao.sw@gmail.com>
Date: Tue, 28 Aug 2018 14:25:04 +0800
Subject: [PATCH] FIX: drop title updates through RSS feeds

can create an update loop
---
 app/models/topic_embed.rb       | 15 ++++-----------
 spec/jobs/poll_feed_spec.rb     |  1 -
 spec/models/topic_embed_spec.rb |  7 -------
 3 files changed, 4 insertions(+), 19 deletions(-)

diff --git a/app/models/topic_embed.rb b/app/models/topic_embed.rb
index cb38ce73fc6..9284c41a76a 100644
--- a/app/models/topic_embed.rb
+++ b/app/models/topic_embed.rb
@@ -74,8 +74,6 @@ class TopicEmbed < ActiveRecord::Base
 
       # Update the topic if it changed
       if post&.topic
-        revision = {}
-
         if post.user != user
           PostOwnerChanger.new(
             post_ids: [post.id],
@@ -89,19 +87,14 @@ class TopicEmbed < ActiveRecord::Base
         end
 
         if content_sha1 != embed.content_sha1
-          revision[:raw] = absolutize_urls(url, contents)
-        end
-
-        revision[:title] = title if title != post.topic.title
-
-        unless revision.empty?
-          post.revise(user, revision,
+          post.revise(
+            user,
+            { raw: absolutize_urls(url, contents) },
             skip_validations: true,
             bypass_rate_limiter: true
           )
+          embed.update!(content_sha1: content_sha1)
         end
-
-        embed.update!(content_sha1: content_sha1) if revision[:raw]
       end
     end
 
diff --git a/spec/jobs/poll_feed_spec.rb b/spec/jobs/poll_feed_spec.rb
index ce79bdb3049..8b151c73bfa 100644
--- a/spec/jobs/poll_feed_spec.rb
+++ b/spec/jobs/poll_feed_spec.rb
@@ -90,7 +90,6 @@ describe Jobs::PollFeed do
             expect { poller.poll_feed }.to_not change { Topic.count }
 
             post.reload
-            expect(post.topic.title).to eq('Poll Feed Spec Fixture')
             expect(post.raw).to include('<p>This is the body &amp; content. </p>')
             expect(post.user).to eq(feed_author)
           end
diff --git a/spec/models/topic_embed_spec.rb b/spec/models/topic_embed_spec.rb
index 813da3ece93..b9e1247929b 100644
--- a/spec/models/topic_embed_spec.rb
+++ b/spec/models/topic_embed_spec.rb
@@ -41,13 +41,6 @@ describe TopicEmbed do
         expect(post.topic.category).to eq(embeddable_host.category)
       end
 
-      it "Supports updating the post title" do
-        TopicEmbed.import(user, url, "I am a new title", contents)
-
-        topic_embed.reload
-        expect(topic_embed.post.topic.title).to eq("I am a new title")
-      end
-
       it "Supports updating the post content" do
         expect do
           TopicEmbed.import(user, url, title, "muhahaha new contents!")