Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: error when flagging to notify moderators because message title is too long

This commit is contained in:
Neil Lalonde 2018-05-29 12:21:47 -04:00
parent ee8cda691d
commit e26a14dc29
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/post_action.rb
View File

@ -245,7 +245,7 @@ SQL
title = I18n.t("post_action_types.#{post_action_type}.email_title", title: post.topic.title, locale: SiteSetting.default_locale) title = I18n.t("post_action_types.#{post_action_type}.email_title", title: post.topic.title, locale: SiteSetting.default_locale)
body = I18n.t("post_action_types.#{post_action_type}.email_body", message: opts[:message], link: "#{Discourse.base_url}#{post.url}", locale: SiteSetting.default_locale) body = I18n.t("post_action_types.#{post_action_type}.email_body", message: opts[:message], link: "#{Discourse.base_url}#{post.url}", locale: SiteSetting.default_locale)
warning = opts[:is_warning] if opts[:is_warning].present? warning = opts[:is_warning] if opts[:is_warning].present?
title = title.truncate(255, separator: /\s/) title = title.truncate(SiteSetting.max_topic_title_length, separator: /\s/)
opts = { opts = {
archetype: Archetype.private_message, archetype: Archetype.private_message,

7
spec/models/post_action_spec.rb
View File

@ -619,6 +619,13 @@ describe PostAction do
end end
end end
it "should succeed even with low max title length" do
SiteSetting.max_topic_title_length = 50
post.topic.title = 'This is a test topic ' * 2
post.topic.save!
message_id = PostAction.create_message_for_post_action(Discourse.system_user, post, PostActionType.types[:notify_moderators], message: "WAT")
expect(message_id).to be_present
end
end end
describe ".lookup_for" do describe ".lookup_for" do