From e27966c9440da5374a74ebf1f5c0d51a98089e26 Mon Sep 17 00:00:00 2001
From: David Taylor <david@taylorhq.com>
Date: Thu, 16 Feb 2023 13:33:40 +0000
Subject: [PATCH] PERF: Remove ember-link-component-extension to enable Glimmer
 LinkTo

Reopening Ember.LinkComponent causes `<LinkTo>` to enter 'legacy mode', and fall back to the Classic Component implementation. The extension added the ability to pass `@name` to the component. Setting a name (or any other attribute) on the new Glimmer implementation can be achieved by passing `name=` (no `@`).

The original use case for this was refactored out during https://github.com/discourse/discourse/commit/d3649873a2. There are no other instances of `@name` being used in core or `all-the-*`.

The update to section-link is required to avoid a warning when an `undefined` value is passed to the argument.
---
 .../app/components/sidebar/section-link.hbs    |  2 +-
 .../ember-link-component-extension.js          | 18 ------------------
 2 files changed, 1 insertion(+), 19 deletions(-)
 delete mode 100644 app/assets/javascripts/discourse/app/initializers/ember-link-component-extension.js

diff --git a/app/assets/javascripts/discourse/app/components/sidebar/section-link.hbs b/app/assets/javascripts/discourse/app/components/sidebar/section-link.hbs
index fb69e071e07..ff18258e889 100644
--- a/app/assets/javascripts/discourse/app/components/sidebar/section-link.hbs
+++ b/app/assets/javascripts/discourse/app/components/sidebar/section-link.hbs
@@ -28,7 +28,7 @@
       <LinkTo
         class={{this.classNames}}
         @route={{@route}}
-        @query={{@query}}
+        @query={{or @query (hash)}}
         @models={{this.models}}
         @current-when={{@currentWhen}}
         title={{@title}}
diff --git a/app/assets/javascripts/discourse/app/initializers/ember-link-component-extension.js b/app/assets/javascripts/discourse/app/initializers/ember-link-component-extension.js
deleted file mode 100644
index 9c2b8e768eb..00000000000
--- a/app/assets/javascripts/discourse/app/initializers/ember-link-component-extension.js
+++ /dev/null
@@ -1,18 +0,0 @@
-import Ember from "ember";
-let initializedOnce = false;
-
-export default {
-  name: "ember-link-component-extensions",
-
-  initialize() {
-    if (initializedOnce) {
-      return;
-    }
-
-    Ember.LinkComponent.reopen({
-      attributeBindings: ["name"],
-    });
-
-    initializedOnce = true;
-  },
-};