FIX: Narrative Bot certificates are ERB templates (#8174)

Browse Source

There are at least two ways of rendering templates outside of the controller. The first one is Rails way enabled with Rails 5 https://evilmartians.com/chronicles/new-feature-in-rails-5-render-views-outside-of-actions
The downside of this method is that all variables need to be passed as params (I could find a way to pass the whole context)

Another way is to use instance_eval described in Erubi documentation
https://github.com/jeremyevans/erubi#usage - it works perfectly fine, however, I didn't feel very confident about using eval unless necessary.

An additional benefit of using `ApplicationController.render` is that if Rails would change the ERB engine in the future, this code should still work.

If you want to test it on your local, you need to be signed in and then that two URLs are generating certificates:
http://localhost:3000/discobot/certificate.svg?date=Oct+07+2019&type=standard&user_id=1
http://localhost:3000/discobot/certificate.svg?date=Oct+07+2019&type=advanced&user_id=1

Dev: https://dev.discourse.org/t/discourse-narrative-bot-should-not-be-storing-giant-strings/17130

...

This commit is contained in:

Krzysztof Kotlarek 2019-10-09 17:45:01 +11:00 committed by Sam

parent 3d5f71dac7

commit e2f9b7dd6f

3 changed files with 543 additions and 535 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show Stats Download Patch File Download Diff File Expand all files Collapse all files

549

plugins/discourse-narrative-bot/lib/discourse_narrative_bot/certificate_generator.rb

View File

File diff suppressed because one or more lines are too long

56

plugins/discourse-narrative-bot/lib/discourse_narrative_bot/templates/advanced_user.svg.erb Normal file

View File

File diff suppressed because one or more lines are too long

Side by Side After Width:  |  Height:  |  Size: 729 KiB

473

plugins/discourse-narrative-bot/lib/discourse_narrative_bot/templates/new_user.svg.erb Normal file

View File

File diff suppressed because one or more lines are too long

Side by Side After Width:  |  Height:  |  Size: 494 KiB