From e4e239c159bdf4973c3710d1fa16bf585d4d789c Mon Sep 17 00:00:00 2001
From: Robin Ward <robin.ward@gmail.com>
Date: Thu, 15 Jan 2015 15:43:20 -0500
Subject: [PATCH] Add some safety when rendering a dropdown button to make sure
 it has content.

---
 .../discourse/views/dropdown-button.js.es6    | 29 ++++++++++---------
 1 file changed, 16 insertions(+), 13 deletions(-)

diff --git a/app/assets/javascripts/discourse/views/dropdown-button.js.es6 b/app/assets/javascripts/discourse/views/dropdown-button.js.es6
index b10d8ad7a4f..e656d6424f6 100644
--- a/app/assets/javascripts/discourse/views/dropdown-button.js.es6
+++ b/app/assets/javascripts/discourse/views/dropdown-button.js.es6
@@ -31,20 +31,23 @@ export default Discourse.View.extend(StringBuffer, {
     buffer.push("</button>");
     buffer.push("<ul class='dropdown-menu'>");
 
-    var self = this;
-    this.get('dropDownContent').forEach(function(row) {
-      var id = row.id,
-          title = row.title,
-          iconClass = row.styleClasses,
-          description = row.description,
-          className = (self.get('activeItem') === id ? 'disabled': '');
+    var contents = this.get('dropDownContent');
+    if (contents) {
+      var self = this;
+      contents.forEach(function(row) {
+        var id = row.id,
+            title = row.title,
+            iconClass = row.styleClasses,
+            description = row.description,
+            className = (self.get('activeItem') === id ? 'disabled': '');
 
-      buffer.push("<li data-id=\"" + id + "\" class=\"" + className + "\"><a href>");
-      buffer.push("<span class='icon " + iconClass + "'></span>");
-      buffer.push("<div><span class='title'>" + title + "</span>");
-      buffer.push("<span>" + description + "</span></div>");
-      buffer.push("</a></li>");
-    });
+        buffer.push("<li data-id=\"" + id + "\" class=\"" + className + "\"><a href>");
+        buffer.push("<span class='icon " + iconClass + "'></span>");
+        buffer.push("<div><span class='title'>" + title + "</span>");
+        buffer.push("<span>" + description + "</span></div>");
+        buffer.push("</a></li>");
+      });
+    }
 
     buffer.push("</ul>");