discourse/discourse
1
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-03-09 14:34:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

UX: show error message instead of disabling save button on tag groups page (#12767)

Browse Source 
https://meta.discourse.org/t/unable-to-rename-tag-groups-title-save-button-stays-grayed-out/172293/
This commit is contained in:
Arpit Jalan 2021-04-20 21:40:02 +05:30 committed by GitHub
parent 48d04e934d
commit e54b5dadab
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
app/assets/javascripts/discourse/app/components/tag-groups-form.js
View File

@ -23,14 +23,12 @@ export default Component.extend(bufferedProperty("model"), {
},
@discourseComputed(
"buffered.isSaving",
"buffered.name",
"buffered.tag_names",
"buffered.permissions"
)
savingDisabled(isSaving, name, tagNames, permissions) {
cannotSave(name, tagNames, permissions) {
return (
isSaving ||
isEmpty(name) ||
isEmpty(tagNames) ||
(!this.everyoneSelected(permissions) &&
@ -116,6 +114,11 @@ export default Component.extend(bufferedProperty("model"), {
},
save() {
if (this.cannotSave) {
bootbox.alert(I18n.t("tagging.groups.cannot_save"));
return false;
}
const attrs = this.buffered.getProperties(
"name",
"tag_names",

2
app/assets/javascripts/discourse/app/templates/components/tag-groups-form.hbs
View File

@ -93,7 +93,7 @@
{{d-button
class="btn-default"
action=(action "save")
disabled=savingDisabled
disabled=buffered.isSaving
label="tagging.groups.save"}}
{{d-button

2
app/assets/javascripts/discourse/tests/acceptance/tag-groups-test.js
View File

@ -66,8 +66,6 @@ acceptance("Tag Groups", function (needs) {
await tags.selectRowByValue("monkey");
await click("#visible-permission");
assert.ok(queryAll(".tag-group-content .btn.btn-default:disabled").length);
await groups.expand();
await groups.selectRowByIndex(1);
await groups.selectRowByIndex(0);

1
config/locales/client.en.yml
View File

@ -3677,6 +3677,7 @@ en:
everyone_can_use: "Tags can be used by everyone"
usable_only_by_groups: "Tags are visible to everyone, but only the following groups can use them"
visible_only_to_groups: "Tags are visible only to the following groups"
cannot_save: "Cannot save tag group. Make sure that there is at least one tag present, tag group name is not empty, and a group is selected for tags permission."
topics:
none: