FIX: File size text should not be part of link.

app/assets/javascripts/discourse/lib/utilities.js.es6

@@ -444,9 +444,9 @@ export function getUploadMarkdown(upload) {
   ) {
     return uploadLocation(upload.url);
   } else {
-    return `[${upload.original_filename} (${I18n.toHumanSize(
-      upload.filesize
-    )})|attachment](${upload.short_url})`;
+    return `[${upload.original_filename}|attachment](${
+      upload.short_url
+    }) (${I18n.toHumanSize(upload.filesize)})`;
   }
 }
 

test/javascripts/lib/utilities-test.js.es6

@@ -194,7 +194,7 @@ QUnit.test("getUploadMarkdown", assert => {
 
   assert.equal(
     testUploadMarkdown("important.txt", { short_url }),
-    `[important.txt (42 Bytes)|attachment](${short_url})`
+    `[important.txt|attachment](${short_url}) (42 Bytes)`
   );
 });