From e6e6d209125f37bbcb5da9e5ec87c78f36cf8f9c Mon Sep 17 00:00:00 2001
From: David Taylor <david@taylorhq.com>
Date: Fri, 27 Mar 2020 11:43:00 +0000
Subject: [PATCH] Revert "DEV: Enable and fix link-href-attributes lint"

Introducing an href attribute on the upload button caused the page to reload when clicked

This reverts commit a17fa222afff6e035d5b610487d6888896913d35.
---
 .template-lintrc.js                                             | 1 -
 .../javascripts/discourse/templates/components/share-panel.hbs  | 2 +-
 .../javascripts/discourse/templates/components/share-popup.hbs  | 2 +-
 app/assets/javascripts/discourse/templates/composer.hbs         | 2 +-
 4 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/.template-lintrc.js b/.template-lintrc.js
index 85a2b8381ea..7c94a35a768 100644
--- a/.template-lintrc.js
+++ b/.template-lintrc.js
@@ -11,7 +11,6 @@ module.exports = {
     "img-alt-attributes": false,
     "linebreak-style": true,
     "link-rel-noopener": true,
-    "link-href-attributes": true,
     "no-abstract-roles": true,
     "no-args-paths": true,
     "no-attrs-in-components": true,
diff --git a/app/assets/javascripts/discourse/templates/components/share-panel.hbs b/app/assets/javascripts/discourse/templates/components/share-panel.hbs
index 4a2b9935cf0..1808d6cc1f0 100644
--- a/app/assets/javascripts/discourse/templates/components/share-panel.hbs
+++ b/app/assets/javascripts/discourse/templates/components/share-panel.hbs
@@ -4,7 +4,7 @@
 
 <div class="body">
   {{textarea value=shareUrl class="topic-share-url"}}
-  <div class="topic-share-url-for-touch"><a href>{{! set by component }}</a></div>
+  <div class="topic-share-url-for-touch"><a></a></div>
 
   <div class="sources">
     {{#each sources as |source|}}
diff --git a/app/assets/javascripts/discourse/templates/components/share-popup.hbs b/app/assets/javascripts/discourse/templates/components/share-popup.hbs
index 38641694bdd..54e8029cf67 100644
--- a/app/assets/javascripts/discourse/templates/components/share-popup.hbs
+++ b/app/assets/javascripts/discourse/templates/components/share-popup.hbs
@@ -8,7 +8,7 @@
 
 <div>
   <input type="text">
-  <div class="share-for-touch"><div class="overflow-ellipsis"><a href>{{! set by component }}</a></div></div>
+  <div class="share-for-touch"><div class="overflow-ellipsis"><a></a></div></div>
 </div>
 
 <div class="actions">
diff --git a/app/assets/javascripts/discourse/templates/composer.hbs b/app/assets/javascripts/discourse/templates/composer.hbs
index e86aefbfe37..43af40a5274 100644
--- a/app/assets/javascripts/discourse/templates/composer.hbs
+++ b/app/assets/javascripts/discourse/templates/composer.hbs
@@ -191,7 +191,7 @@
 
               {{#if site.mobileView}}
                 {{#if allowUpload}}
-                  <a href class="btn btn-default no-text mobile-file-upload {{if isUploading 'hidden'}}">
+                  <a class="btn btn-default no-text mobile-file-upload {{if isUploading 'hidden'}}">
                     {{d-icon uploadIcon}}
                   </a>
                 {{/if}}