From e6eb16ee73c99d4afc45baf1271c8a6f41948c08 Mon Sep 17 00:00:00 2001 From: Vikhyat Korrapati Date: Fri, 18 Apr 2014 09:10:18 +0530 Subject: [PATCH] Fix infinite loading spinner for badges that have not been granted yet. --- app/assets/javascripts/discourse/routes/badges_show_route.js | 1 + .../javascripts/discourse/templates/badges/show.js.handlebars | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/app/assets/javascripts/discourse/routes/badges_show_route.js b/app/assets/javascripts/discourse/routes/badges_show_route.js index d0769325040..88e022cb187 100644 --- a/app/assets/javascripts/discourse/routes/badges_show_route.js +++ b/app/assets/javascripts/discourse/routes/badges_show_route.js @@ -18,6 +18,7 @@ Discourse.BadgesShowRoute = Ember.Route.extend({ setupController: function(controller, model) { Discourse.UserBadge.findByBadgeId(model.get('id')).then(function(userBadges) { controller.set('userBadges', userBadges); + controller.set('userBadgesLoaded', true); }); controller.set('model', model); } diff --git a/app/assets/javascripts/discourse/templates/badges/show.js.handlebars b/app/assets/javascripts/discourse/templates/badges/show.js.handlebars index 7f0b70167f8..22681594ed4 100644 --- a/app/assets/javascripts/discourse/templates/badges/show.js.handlebars +++ b/app/assets/javascripts/discourse/templates/badges/show.js.handlebars @@ -22,6 +22,8 @@ {{/link-to}} {{/each}} {{else}} -
{{i18n loading}}
+ {{#unless userBadgesLoaded}} +
{{i18n loading}}
+ {{/unless}} {{/if}}