Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: Skip gsub for normalizing whitespaces when text is nil (#6631)

This commit is contained in:
Rishabh 2018-11-20 13:42:32 +05:30 committed by Régis Hanol
parent bc41057949
commit eacbe28f55
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/text_cleaner.rb
View File

@ -57,7 +57,7 @@ class TextCleaner
@@whitespaces_regexp = Regexp.new("(\u00A0|\u1680|\u180E|[\u2000-\u200A]|\u2028|\u2029|\u202F|\u205F|\u3000)", "u").freeze
def self.normalize_whitespaces(text)
text.gsub(@@whitespaces_regexp, ' ')
text&.gsub(@@whitespaces_regexp, ' ')
end
end

1
spec/components/text_cleaner_spec.rb
View File

@ -218,6 +218,7 @@ describe TextCleaner do
whitespaces = "\u0020\u00A0\u1680\u180E\u2000\u2001\u2002\u2003\u2004\u2005\u2006\u2007\u2008\u2009\u200A\u2028\u2029\u202F\u205F\u3000"
expect(whitespaces.strip).not_to eq("")
expect(TextCleaner.normalize_whitespaces(whitespaces).strip).to eq("")
expect(TextCleaner.normalize_whitespaces(nil)).to be_nil
end
it "does not muck with zero width white space" do