Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: page tracking was not properly tracking transitions 

PERF: move closure to self contained method so env is released earlier.
This commit is contained in:
Sam 2015-09-17 11:06:21 +10:00
parent fbfdb4c28a
commit ec4a1bb2c4
2 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/discourse/mixins/ajax.js
View File

@ -49,7 +49,7 @@ Discourse.Ajax = Em.Mixin.create({
if (_trackView && (!args.type || args.type === "GET")) {
_trackView = false;
// DON'T CHANGE: rack is prepending "HTTP_" in the header's name
args.headers['DISCOURSE_TRACK_VIEW'] = true;
args.headers['Discourse-Track-View'] = "true";
}
args.success = function(data, textStatus, xhr) {

11
lib/middleware/request_tracker.rb
View File

@ -57,6 +57,7 @@ class Middleware::RequestTracker
track_view = status == 200
track_view &&= env_track_view != "0".freeze && env_track_view != "false".freeze
track_view &&= env_track_view || (request.get? && !request.xhr? && headers[CONTENT_TYPE] =~ /text\/html/)
track_view = !!track_view
{
status: status,
@ -77,11 +78,15 @@ class Middleware::RequestTracker
host = RailsMultisite::ConnectionManagement.host(env)
if data
Scheduler::Defer.later("Track view", _db=nil) do
self.class.log_request_on_site(data,host)
end
log_later(data,host)
end
end
def log_later(data,host)
Scheduler::Defer.later("Track view", _db=nil) do
self.class.log_request_on_site(data,host)
end
end
end