FEATURE: Improve header meta alignment and truncation with css grid (#10238)

This commit is contained in:
Kris 2020-07-15 19:30:35 -04:00 committed by GitHub
parent a04573c28e
commit ee88666bad
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 25 additions and 20 deletions

View File

@ -238,9 +238,25 @@
.extra-info { .extra-info {
overflow: hidden; overflow: hidden;
width: 100%; width: 100%;
-webkit-animation: fadein 0.5s;
animation: fadein 0.5s; animation: fadein 0.5s;
} }
.title-wrapper {
display: grid;
grid-template-areas:
"title title"
"categories extra";
grid-template-columns: auto minmax(2em, 1fr); // min must be as wide as ellipsis
align-items: baseline;
.header-title {
grid-area: title;
}
.categories-wrapper {
grid-area: categories;
}
.topic-header-extra {
grid-area: extra;
}
}
.topic-link { .topic-link {
color: $header_primary; color: $header_primary;
display: block; display: block;
@ -255,35 +271,22 @@
} }
} }
.header-title { .header-title {
// bottom margin here is very fragile, causes tag misalignment padding: 0;
margin: 0 0 0.15em 0; margin: 0;
.archetype-private_message & {
// PMs might have participant avatars in the header
margin: 0;
}
font-size: $font-up-3; font-size: $font-up-3;
width: 100%; width: 100%;
} }
.categories-wrapper { .categories-wrapper {
display: inline-flex; display: inline-flex;
align-items: center;
// Protection against a very rare edge case in mobile header for topics with
// very long category names and lots of tags at the same time
max-width: 80%;
flex: 0 1 auto; flex: 0 1 auto;
min-width: 1px; @include ellipsis;
.badge-wrapper { .badge-wrapper {
@include ellipsis; @include ellipsis;
} }
} }
.badge-wrapper { .badge-wrapper {
margin-right: 8px; margin-right: 0.7em;
} min-width: 2.75em; // min needed for ellipsis
.badge-wrapper.bullet {
.badge-category-parent-bg,
.badge-category-bg {
min-width: 5px;
}
} }
.badge-wrapper { .badge-wrapper {
&.bullet, &.bullet,
@ -303,6 +306,7 @@
@include ellipsis; @include ellipsis;
.discourse-tag { .discourse-tag {
display: inline; // tags need to stay inline in order for them to truncate display: inline; // tags need to stay inline in order for them to truncate
vertical-align: unset;
} }
} }
} }
@ -316,8 +320,8 @@ $mobile-avatar-height: 1.532em;
.topic-header-participants { .topic-header-participants {
display: flex; display: flex;
align-items: center; align-items: center;
overflow: hidden;
font-size: $font-down-1; font-size: $font-down-1;
@include ellipsis;
&:not(:first-child) { &:not(:first-child) {
margin-left: 5px; margin-left: 5px;
} }
@ -346,6 +350,7 @@ $mobile-avatar-height: 1.532em;
padding: 0 5px; padding: 0 5px;
border: 1px solid $primary-low; border: 1px solid $primary-low;
border-radius: 0.25em; border-radius: 0.25em;
min-width: 3em;
@include ellipsis; @include ellipsis;
.icon { .icon {