PERF: Remove N+1 query in `SiteSerializer#user_color_schemes`.

2021-06-02 13:26:09 +08:00 · 2021-06-02 13:26:09 +08:00 · eea9fead63
parent 2e4182b4b3
commit eea9fead63
1 changed files with 1 additions and 1 deletions
--- a/app/serializers/site_serializer.rb
+++ b/app/serializers/site_serializer.rb
@ -50,7 +50,7 @@ class SiteSerializer < ApplicationSerializer

  def user_color_schemes
    cache_fragment("user_color_schemes") do
-      schemes = ColorScheme.where('user_selectable').order(:name)
+      schemes = ColorScheme.includes(:color_scheme_colors).where('user_selectable').order(:name)
      ActiveModel::ArraySerializer.new(schemes, each_serializer: ColorSchemeSelectableSerializer).as_json
    end
  end